seen in logstash for wmf/1.29.0-wmf.21
also see:
Notice: Undefined variable: classes in /srv/mediawiki/php-1.29.0-wmf.21/extensions/Flow/Hooks.php on line 553
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • mmodell | T161733 MW-1.29.0-wmf.21 deployment blockers | |||
| Resolved | PRODUCTION ERROR | SBisson | T163896 Warning: onEnhancedChangesListModifyBlockLineData() expects exactly 4 parameters, 3 given in /srv/mediawiki/php-1.29.0-wmf.21/extensions/Flow/Hooks.php on line 538 |
Event Timeline
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2017-04-26T19:42:15Z] <twentyafterfour> rolling back group1 to wmf.20 due to T163896 refs T161733
Comment Actions
this is happening A LOT after promoting group1. Rolling back to wmf.20, this is now a blocker for the wmf.21 train to proceed.
Comment Actions
I'm still trying to track down where the 3-arg call is coming from - I don't see any code that calls that method with 3 args.
Comment Actions
includes/changes/EnhancedChangesList.php:670 is calling the 'EnhancedChangesListModifyBlockLineData' hook with 3 args
We introduced this problem with a change in Flow recently. I'll fix it.
Comment Actions
Change 350477 had a related patch set uploaded (by Sbisson):
[mediawiki/extensions/Flow@master] Make onEnhancedChangesListModifyBlockLineData expect 3 args
Comment Actions
Change 350477 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Make onEnhancedChangesListModifyBlockLineData expect 3 args
Comment Actions
Change 350481 had a related patch set uploaded (by 20after4; owner: Sbisson):
[mediawiki/extensions/Flow@wmf/1.29.0-wmf.21] Make onEnhancedChangesListModifyBlockLineData expect 3 args
Comment Actions
Change 350481 merged by jenkins-bot:
[mediawiki/extensions/Flow@wmf/1.29.0-wmf.21] Make onEnhancedChangesListModifyBlockLineData expect 3 args
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2017-04-26T21:07:59Z] <twentyafterfour@naos> Synchronized php-1.29.0-wmf.21/extensions/Flow/Hooks.php: sync https://gerrit.wikimedia.org/r/#/c/350481/ refs T163896 T161733 (duration: 01m 20s)