Page MenuHomePhabricator
Create Task
Maniphest T163916

CodeMirror enable/disable tooltips need to be switched
Closed, ResolvedPublic
Actions

Description

Right now when CodeMirror is disabled, the tooltip says "Disable CodeMIrror", and when it is enabled, it says "Enable CodeMirror". These should be switched.

Details

SubjectRepoBranchLines +/-
Swap the enable/disable labelsmediawiki/extensions/CodeMirrormaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

kaldari created this task.Apr 26 2017, 4:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2017, 4:11 PM
kaldari moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Apr 26 2017, 4:11 PM
kaldari added a subscriber: Pastakhov.
Pastakhov claimed this task.Apr 26 2017, 4:48 PM

Patch already exists

gerritbot subscribed.Apr 26 2017, 4:48 PM

Change 348675 had a related patch set uploaded (by Pastakhov):
[mediawiki/extensions/CodeMirror@master] Swap the enable/disable labels

https://gerrit.wikimedia.org/r/348675

gerritbot added a project: Patch-For-Review.Apr 26 2017, 4:48 PM
Pastakhov added a comment.EditedApr 26 2017, 5:00 PM

Not sure about icons. Originally the colored icon was displayed when the CodeMirror was disabled and the colorless icon when CodeMirror was enabled. It meant that clicking on colored icon makes wikitext color, and clicking colorless icon makes wikitext colorless...
Maybe the question for T163919

kaldari closed this task as Resolved.Apr 26 2017, 5:16 PM
kaldari moved this task from Needs Discussion to Archive on the Community-Tech board.
kaldari mentioned this in T163919: Design review for CodeMirror extension.
gerritbot added a comment.Apr 26 2017, 5:19 PM

Change 348675 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Swap the enable/disable labels

https://gerrit.wikimedia.org/r/348675

• Niharika subscribed.Apr 26 2017, 5:24 PM

I'm pretty sure it should be colored when CodeMirror is enabled and greyed out when disabled.

Liuxinyu970226 moved this task from Backlog to Done on the MediaWiki-extensions-CodeMirror board.Feb 9 2018, 4:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL