Page MenuHomePhabricator
Create Task
Maniphest T164312

Consolidate references / citations
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

apps-android-wikipedia/www/js/transforms/hideRefs.js
apps-android-wikipedia/www/js/action.js
wikipedia-ios/www/js/refs.js
this has a lot of overlap with collapse table

Try to focus on the iOS implementation which has more recent fixes and enhanced capabilities. This task may also be able to leverage the CollapseTable transform.

Related Objects
Search...

Event Timeline

• Niedzielski created this task.May 2 2017, 10:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 2 2017, 10:14 PM
• Niedzielski triaged this task as Medium priority.May 2 2017, 10:19 PM
• Niedzielski added a parent task: T163839: Phase one: consolidate the JavaScript transforms and associated CSS.
• Niedzielski updated the task description. (Show Details)
• Niedzielski moved this task from Open to Phase One on the wikimedia-page-library board.May 3 2017, 10:14 PM
Mhurd edited projects, added wikimedia-page-library-tshirt; removed wikimedia-page-library.May 11 2017, 9:31 PM
• Niedzielski updated the task description. (Show Details)May 15 2017, 10:18 PM
• Niedzielski created subtask T165431: Integrate references / citations on Android.
• Niedzielski created subtask T165432: Integrate references / citations on iOS.May 15 2017, 10:20 PM
• Niedzielski updated the task description. (Show Details)Jun 5 2017, 7:41 PM
• Niedzielski moved this task from Backlog to M on the wikimedia-page-library-tshirt board.
• Niedzielski set the point value for this task to 2.Jun 5 2017, 8:18 PM
Mhurd claimed this task.Jan 11 2018, 12:00 AM
Mhurd added a project: iOS-app-v5.8.0-Manatee-On-A-Skateboard.
Mhurd moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.
Mhurd added a comment.Jan 11 2018, 12:05 AM

Need to chat about this a bit before we go further.

Questions:

  • How does new references endpoint factor into this?
  • Should we wait until we use new article content service (which presumable doesn't transfer reference html) and hit the references endpoint lazily the first time a user taps a ref? We'd probably want to store refs so we only have to fetch once - would probably have to update from references endpoint if we update article in data store so they'd remain in sync.
Mhurd added a subscriber: • JMinor.Jan 11 2018, 12:06 AM

@JMinor I moved this to Needs Engineering Sync per our chat.

Mhurd moved this task from Needs Engineering Sync to Doing on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Jan 30 2018, 12:38 AM
Mhurd moved this task from Doing to Blocked or Waiting on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Feb 7 2018, 8:00 PM
• JMinor removed a project: iOS-app-v5.8.0-Manatee-On-A-Skateboard.Feb 27 2018, 7:22 PM
• Charlotte subscribed.Mar 12 2018, 6:20 PM

@JMinor @Mhurd Whatever became of this ticket?

Mhurd closed this task as Resolved.Feb 11 2019, 8:12 PM

@Charlotte sorry i missed your message above! i did some work consolidating iOS/Android reference JS ( https://github.com/wikimedia/wikimedia-page-library/pull/140 ), so we can close this ticket. once we switch over to the new article PCS i think we'll need to get ref info from the refs endpoint, but that's separate from this task,

Mhurd closed subtask T165432: Integrate references / citations on iOS as Resolved.Feb 11 2019, 8:16 PM
• Charlotte closed subtask T165431: Integrate references / citations on Android as Declined.Aug 19 2019, 4:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits