Merge alternate SliderView code and replace old SliderView
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	WMDE-Fisch
	May 19 2017, 12:42 PM

Description

merge codebase into one class
remove not needed methods
cleanup and adjust browser tests

(be aware that we might need the clicking of the bars again though)

Details

	Subject	Repo	Branch	Lines +/-
	Remove last SliderViewTwo parts	mediawiki/extensions/RevisionSlider	master	+4 -64
	Merge SliderViewTwo CSS into main CSS	mediawiki/extensions/RevisionSlider	master	+109 -261

Customize query in gerrit

Related Objects

Mentioned In: rERSLedfd88554333: Remove last SliderViewTwo parts
rERSL6ac35ad8b3df: Remove last SliderViewTwo parts
rERSLcdfc529d2c78: Remove last SliderViewTwo parts
rERSL82ac35a25074: Remove last SliderViewTwo parts
rERSL12e34322bc3a: Merge SliderViewTwo CSS into main CSS
rERSL8bb9037d8082: Merge SliderViewTwo CSS into main CSS

Event Timeline

WMDE-Fisch created this task.May 19 2017, 12:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 19 2017, 12:42 PM

• Lea_WMDE moved this task from Incoming to Maintenance on the Revision-Slider board.May 20 2017, 6:48 AM

• Lea_WMDE added a project: WMDE-TechWish.May 21 2017, 7:53 PM

• Lea_WMDE updated the task description. (Show Details)

Tobi_WMDE_SW moved this task from Proposed to Todo on the WMDE-TechWish board.May 31 2017, 12:50 PM

Tobi_WMDE_SW moved this task from Incoming to Revision Slider on the TCB-Team (now WMDE-TechWish) board.Jun 6 2017, 10:10 AM

Tobi_WMDE_SW moved this task from Todo to Proposed on the WMDE-TechWish board.Jun 6 2017, 3:29 PM

Change 360613 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/RevisionSlider@master] Merge SliderViewTwo CSS into main CSS

https://gerrit.wikimedia.org/r/360613

gerritbot added a project: Patch-For-Review.Jun 21 2017, 8:10 AM

WMDE-Fisch mentioned this in rERSL8bb9037d8082: Merge SliderViewTwo CSS into main CSS.Jun 21 2017, 8:11 AM

WMDE-Fisch mentioned this in rERSL12e34322bc3a: Merge SliderViewTwo CSS into main CSS.Jun 21 2017, 8:14 AM

Change 360613 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Merge SliderViewTwo CSS into main CSS

https://gerrit.wikimedia.org/r/360613

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)).Jun 21 2017, 1:00 PM

Change 363162 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/RevisionSlider@master] Remove last SliderViewTwo parts

https://gerrit.wikimedia.org/r/363162

WMDE-Fisch claimed this task.Jul 4 2017, 10:36 AM

WMDE-Fisch moved this task from Proposed to Currently in sprint on the WMDE-TechWish board.

WMDE-Fisch removed a project: MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)).

WMDE-Fisch mentioned this in rERSL82ac35a25074: Remove last SliderViewTwo parts.Jul 4 2017, 10:38 AM

WMDE-Fisch mentioned this in rERSLcdfc529d2c78: Remove last SliderViewTwo parts.Jul 4 2017, 12:18 PM

WMDE-Fisch mentioned this in rERSL6ac35ad8b3df: Remove last SliderViewTwo parts.Jul 5 2017, 7:51 AM

WMDE-Fisch mentioned this in rERSLedfd88554333: Remove last SliderViewTwo parts.Jul 5 2017, 8:23 AM

Change 363162 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Remove last SliderViewTwo parts

https://gerrit.wikimedia.org/r/363162

WMDE-Fisch moved this task from Currently in sprint to Done on the WMDE-TechWish board.Jul 6 2017, 11:36 AM

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)).Jul 8 2017, 3:01 AM