Page MenuHomePhabricator
Create Task
Maniphest T165865

Table row context menu appears too far below
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Table row context menu appears too far below. The highest the table row is, the further down from the correct position the menu appears.

image.png (968×1 px, 158 KB)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (b528a5321)mediawiki/extensions/VisualEditormaster+50 -1
Update VE core submodule to master (b528a5321)mediawiki/extensions/VisualEditormaster+1 -1
ve.ui.TableLineContext: Fancier popupsVisualEditor/VisualEditormaster+11 -28
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.May 20 2017, 11:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2017, 11:59 AM
gerritbot subscribed.May 20 2017, 12:43 PM

Change 354679 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.ui.TableLineContext: Fancier popups

https://gerrit.wikimedia.org/r/354679

gerritbot added a project: Patch-For-Review.May 20 2017, 12:43 PM
• Deskana added subscribers: Jdforrester-WMF, • Deskana.Jun 27 2017, 7:25 PM

@Jdforrester-WMF says that the above patch works in standalone VE, but makes it worse in MediaWiki. @matmarex, do you plan on addressing these issues any time soon? :-)

matmarex added a comment.Jun 28 2017, 2:51 PM

Yes, I've been working on some higher priority issues (this is mostly just a cosmetic problem) but I'll look into it now.

gerritbot added a comment.Jun 28 2017, 7:28 PM

Change 354679 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ui.TableLineContext: Fancier popups

https://gerrit.wikimedia.org/r/354679

gerritbot added a comment.Jun 28 2017, 7:46 PM

Change 361940 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b528a5321)

https://gerrit.wikimedia.org/r/361940

gerritbot added a comment.Jun 28 2017, 7:58 PM

Change 361890 had a related patch set uploaded (by Jforrester; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b528a5321)

https://gerrit.wikimedia.org/r/361890

gerritbot added a comment.Jun 28 2017, 10:30 PM

Change 361940 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b528a5321)

https://gerrit.wikimedia.org/r/361940

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)).Jun 28 2017, 11:00 PM
Jdforrester-WMF closed this task as Resolved.Jun 29 2017, 7:28 AM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF edited projects, added VisualEditor-Tables; removed Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 29 2017, 7:28 AM
gerritbot added a comment.Jun 29 2017, 7:39 AM

Change 361890 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b528a5321)

https://gerrit.wikimedia.org/r/361890

matmarex merged a task: T170088: Selecting multiple table rows causes the popupwidget to display far below the rows.Jul 11 2017, 7:30 PM
matmarex added a subscriber: Quiddity.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL