Unknown project should not cause an Internal Server Error
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	kaldari
	May 25 2017, 6:29 PM

Description

If you give the Admin stats interface a project name that doesn't exist, it returns a 500 internal server error:
http://tools.wmflabs.org/xtools-dev/adminstats/Blah

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Matthewrbowker	T153112 Epic: Rewriting XTools
		Resolved		Matthewrbowker	T166332 Unknown project should not cause an Internal Server Error

Event Timeline

kaldari created this task.May 25 2017, 6:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 25 2017, 6:29 PM

kaldari triaged this task as Medium priority.May 25 2017, 6:29 PM

kaldari moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.

kaldari set the point value for this task to 1.

kaldari moved this task from Needs Discussion to Up Next (June 3-21) on the Community-Tech board.

I'll take a look

Matthewrbowker added a parent task: T153112: Epic: Rewriting XTools.May 25 2017, 6:58 PM

I do not think it is a good idea to throw an exception when a project does not exist. databasePrepare() in LabsHelper.php must change. Having some kind of error "pipeline" would also help notify users something is going wrong.

It looks like this happens in the Edit Counter interface as well. Put in a bogus project and you get a 500 error:
http://tools.wmflabs.org/xtools-dev/ec/dfgdfg/Kaldari

Yes, I've had a todo list item for a while. The expected behavior is to add a "flash notice" then redirect back to the form.

@Superyetkin Indeed. Error pipline is defined above, and there is also a TODO comment at https://phabricator.wikimedia.org/source/tool-xtools-rebirth/browse/master/src/AppBundle/Helper/LabsHelper.php;7afccb7ee0de515c06149549c420df77ce6a2bda$48

@kaldari Yes, every interface that uses databasePrepare() will have this problem.

Matthewrbowker renamed this task from Admin stats fatals if project isn't recognized to Unknown project should not cause an Internal Server Error.May 25 2017, 8:55 PM

• DannyH edited projects, added Community-Tech-Sprint; removed Community-Tech.May 26 2017, 8:24 PM

Matthewrbowker mentioned this in rXTR9a95df3991bd: Fixes for invalid projects throwing 500 errors, and redirect loops based on….Jun 1 2017, 1:21 AM

https://github.com/x-tools/xtools-rebirth/pull/33

Matthewrbowker mentioned this in rXTR6912d9c97598: Merge pull request #33 from x-tools/T166332.Jun 2 2017, 10:28 PM

Pull Request merged.

• DannyH moved this task from Ready to Q1 2018-19 on the Community-Tech-Sprint board.Jun 5 2017, 5:14 PM

• DannyH edited projects, added Community-Tech; removed Community-Tech-Sprint.Jun 6 2017, 9:16 PM

• DannyH moved this task from Up Next (June 3-21) to Archive on the Community-Tech board.Jun 6 2017, 9:27 PM

Matthewrbowker mentioned this in rXT9a95df3991bd: Fixes for invalid projects throwing 500 errors, and redirect loops based on….Jul 17 2017, 3:09 AM

Matthewrbowker mentioned this in rXT6912d9c97598: Merge pull request #33 from x-tools/T166332.

MusikAnimal moved this task from Working to Complete on the XTools board.Jul 23 2017, 7:33 PM

Matthewrbowker mentioned this in rXTRMRB9a95df3991bd: Fixes for invalid projects throwing 500 errors, and redirect loops based on….Feb 13 2018, 1:34 PM