|Resolved||Matthewrbowker||T153112 Epic: Rewriting XTools|
|Resolved||Matthewrbowker||T166332 Unknown project should not cause an Internal Server Error|
- Mentioned In
- rXTRMRB9a95df3991bd: Fixes for invalid projects throwing 500 errors, and redirect loops based on…
rXTRMRB6912d9c97598: Merge pull request #33 from x-tools/T166332
rXT6912d9c97598: Merge pull request #33 from x-tools/T166332
rXT9a95df3991bd: Fixes for invalid projects throwing 500 errors, and redirect loops based on…
rXTR6912d9c97598: Merge pull request #33 from x-tools/T166332
rXTR9a95df3991bd: Fixes for invalid projects throwing 500 errors, and redirect loops based on…
I do not think it is a good idea to throw an exception when a project does not exist. databasePrepare() in LabsHelper.php must change. Having some kind of error "pipeline" would also help notify users something is going wrong.
Yes, I've had a todo list item for a while. The expected behavior is to add a "flash notice" then redirect back to the form.
@Superyetkin Indeed. Error pipline is defined above, and there is also a TODO comment at https://phabricator.wikimedia.org/source/tool-xtools-rebirth/browse/master/src/AppBundle/Helper/LabsHelper.php;7afccb7ee0de515c06149549c420df77ce6a2bda$48
@kaldari Yes, every interface that uses databasePrepare() will have this problem.