Page MenuHomePhabricator

Unknown project should not cause an Internal Server Error
Closed, ResolvedPublic1 Estimated Story Points


If you give the Admin stats interface a project name that doesn't exist, it returns a 500 internal server error:

Event Timeline

kaldari created this task.May 25 2017, 6:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 25 2017, 6:29 PM
kaldari triaged this task as Medium priority.May 25 2017, 6:29 PM
kaldari set the point value for this task to 1.
kaldari moved this task from To Be Estimated/Discussed to Estimated on the Community-Tech board.
Matthewrbowker moved this task from Backlog to Working on the XTools board.
Matthewrbowker added a subscriber: Matthewrbowker.

I'll take a look

I do not think it is a good idea to throw an exception when a project does not exist. databasePrepare() in LabsHelper.php must change. Having some kind of error "pipeline" would also help notify users something is going wrong.

It looks like this happens in the Edit Counter interface as well. Put in a bogus project and you get a 500 error:

Matthewrbowker added a comment.EditedMay 25 2017, 8:54 PM

Yes, I've had a todo list item for a while. The expected behavior is to add a "flash notice" then redirect back to the form.

@Superyetkin Indeed. Error pipline is defined above, and there is also a TODO comment at;7afccb7ee0de515c06149549c420df77ce6a2bda$48

@kaldari Yes, every interface that uses databasePrepare() will have this problem.

Matthewrbowker renamed this task from Admin stats fatals if project isn't recognized to Unknown project should not cause an Internal Server Error.May 25 2017, 8:55 PM
Matthewrbowker closed this task as Resolved.Jun 4 2017, 5:30 PM

Pull Request merged.

DannyH moved this task from Ready to Q1 2018-19 on the Community-Tech-Sprint board.Jun 5 2017, 5:14 PM
DannyH moved this task from Estimated to Archive on the Community-Tech board.Jun 6 2017, 9:27 PM
MusikAnimal moved this task from Working to Complete on the XTools board.Jul 23 2017, 7:33 PM