T there's a revision-create event emitted for every single revision in the page history when the page is undeleted. When the page is deleted and restored, revision-create events are sent for all the historic revisions of the page
It's a big problem because it might make change-prop re-renader content a lot, however right now all of the extra events are being deduplicated.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Use PageContentSaveComplete hook for revision-create. | mediawiki/extensions/EventBus | master | +53 -55 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Pchelolo | T166351 Revision create events are made for all history of a page when it is undeleted | |||
| Declined | None | T188396 It should be possible to understand the reason of revision creation from RevisionRecordInserted hook |
Not reproducible in beta.
However, in beta cluster when the page is deleted and restored, revision-create events are sent for all the historic revisions of the page
This bit is confusing. Is it reproducible in beta or not?
This bit is confusing. Is it reproducible in beta or not?
Oh, sorry. So the original bug when the page is renamed and all the historic revisions are inserted again is not happening in the beta cluster.
However, I've discovered another unexpected behavior with page restoration. That one is not a bug, apparently it's expected behavior we just were not aware of. That one is reproducible. I should probably split this ticket in 2
Change 458906 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/EventBus@master] Use PageContentSaveComplete hook for revision-create.
Change 458906 merged by jenkins-bot:
[mediawiki/extensions/EventBus@master] Use PageContentSaveComplete hook for revision-create.