Page MenuHomePhabricator

pin icon looks to small since OOjs UI v0.22 got taller buttons
Closed, ResolvedPublic

Description

OOjs UI v0.22 increased padding on buttons so they are easier to hit especially on mobile devices. This also affects the top bar of the RevisionSlider and the pin button now looks a bit lost. See screenshot.

We could:
a) increase the size of the pin
b) reduce the padding of the bar

We should definitely do something before deployment train starts next Tuesday.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 1 2017, 5:03 PM
WMDE-Fisch moved this task from Proposed to Todo on the WMDE-QWERTY-Team board.Jun 1 2017, 5:03 PM

OK, lets look at this together in the browser, I probably make wrong assumptions about hit area and technical possibilities if I use the image (which is very useful for seeing the problem!) :-)

WMDE-Fisch moved this task from Todo to Sprint ready on the WMDE-QWERTY-Team board.

Short 1on1 feedback with Jan: We will adjust the pin size to go with the taller bar.

Change 357365 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/RevisionSlider@master] Adjust pin layout to new OOjs UI defaults

https://gerrit.wikimedia.org/r/357365

Change 357365 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Adjust pin layout to new OOjs UI defaults

https://gerrit.wikimedia.org/r/357365

Tobi_WMDE_SW closed this task as Resolved.Jun 6 2017, 11:43 AM
Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-QWERTY-Team board.Jun 6 2017, 2:30 PM