Stop js from jumping on page load
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lea_WMDE
	Jun 6 2017, 1:49 PM

Description

Motivation
Currently, at times there is jumping js when loading our page: The "select default version" box makes the text above the editor change as well, which is sometimes visible to the users.

Task
Remove the jumpiness of the js by using the class "client-js" as explained in T165488: [Hackathon 2017] "Progressive Enhancement": Added JS makes UI jump

Details

	Subject	Repo	Branch	Lines +/-
	Use client-js class to set JS element visibility	mediawiki/extensions/TwoColConflict	master	+17 -8

Customize query in gerrit

Related Objects

Mentioned In: rESCC718641c9e427: Use client-js class to set JS element visibility
Mentioned Here: T165488: [Hackathon 2017] "Progressive Enhancement": Added JS makes UI jump

Event Timeline

Lea_WMDE created this task.Jun 6 2017, 1:49 PM

Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptJun 6 2017, 1:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Tobi_WMDE_SW moved this task from Incoming to Edit Conflict Handling on the TCB-Team (now WMDE-TechWish) board.Jun 7 2017, 3:14 PM

Change 363028 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/TwoColConflict@master] Use client-js class to set JS element visibility

https://gerrit.wikimedia.org/r/363028

gerritbot added a project: Patch-For-Review.Jul 3 2017, 4:40 PM

WMDE-Fisch mentioned this in rESCC718641c9e427: Use client-js class to set JS element visibility.Jul 3 2017, 4:40 PM

WMDE-Fisch claimed this task.Jul 3 2017, 5:00 PM

WMDE-Fisch moved this task from Proposed to Currently in sprint on the WMDE-TechWish board.

WMDE-Fisch moved this task from Currently in sprint to Done on the WMDE-TechWish board.Jul 6 2017, 9:27 PM

Change 363028 merged by WMDE-Fisch:
[mediawiki/extensions/TwoColConflict@master] Use client-js class to set JS element visibility

https://gerrit.wikimedia.org/r/363028

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)).Jul 8 2017, 4:01 AM

WMDE-Fisch closed this task as Resolved.Jul 11 2017, 4:18 PM

WMDE-Fisch moved this task from Done to Demoed on the WMDE-TechWish board.

thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 3:25 PM