Page MenuHomePhabricator
Create Task
Maniphest T167354

LoginNotify attempts to connect to wiki '0'
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Seen in prod on test wiki, not reproduceable on demand:

2017-06-07 08:23:58 [WTe4GwpAIDQAAC3YgmkAAABY] mw1182 testwiki 1.30.0-wmf.4 exception ERROR: [WTe4GwpAIDQAAC3YgmkAAABY] /w/index.php?title=Special
:UserLogin&returnto=Main+Page   Wikimedia\Rdbms\DBConnectionError from line 788 of /srv/mediawiki/php-1.30.0-wmf.4/includes/libs/rdbms/database/Da
tabase.php: Cannot access the database: Access denied for user 'wikiuser'@'10.64.%' to database '0' (10.64.32.136) {"exception_id":"WTe4GwpAIDQAAC
3YgmkAAABY","caught_by":"mwe_handler"}
[Exception Wikimedia\Rdbms\DBConnectionError] (/srv/mediawiki/php-1.30.0-wmf.4/includes/libs/rdbms/database/Database.php:788) Cannot access the database: Access denied for user 'wikiuser'@'10.64.%' to database '0' (10.64.32.136)
  #0 /srv/mediawiki/php-1.30.0-wmf.4/includes/libs/rdbms/loadbalancer/LoadBalancer.php(995): Wikimedia\Rdbms\Database->reportConnectionError(string)
  #1 /srv/mediawiki/php-1.30.0-wmf.4/includes/libs/rdbms/loadbalancer/LoadBalancer.php(666): Wikimedia\Rdbms\LoadBalancer->reportConnectionError()
  #2 /srv/mediawiki/php-1.30.0-wmf.4/extensions/LoginNotify/LoginNotify_body.php(214): Wikimedia\Rdbms\LoadBalancer->getConnection(integer, array, integer)
  #3 /srv/mediawiki/php-1.30.0-wmf.4/extensions/LoginNotify/LoginNotify_body.php(113): LoginNotify->isUserInCheckUser(User)
  #4 /srv/mediawiki/php-1.30.0-wmf.4/extensions/LoginNotify/LoginNotify_body.php(634): LoginNotify->isFromKnownIP(User)
  #5 /srv/mediawiki/php-1.30.0-wmf.4/extensions/LoginNotify/LoginNotify.hooks.php(157): LoginNotify->recordFailure(User)
  #6 /srv/mediawiki/php-1.30.0-wmf.4/extensions/LoginNotify/LoginNotify.hooks.php(131): LoginNotifyHooks::doFailedLogin(User)
  #7 /srv/mediawiki/php-1.30.0-wmf.4/includes/Hooks.php(186): LoginNotifyHooks::onAuthManagerLoginAuthenticateAudit(MediaWiki\Auth\AuthenticationResponse, NULL, string)
  #8 /srv/mediawiki/php-1.30.0-wmf.4/includes/auth/AuthManager.php(470): Hooks::run(string, array)
  #9 /srv/mediawiki/php-1.30.0-wmf.4/includes/auth/AuthManager.php(382): MediaWiki\Auth\AuthManager->continueAuthentication(array)
  #10 /srv/mediawiki/php-1.30.0-wmf.4/includes/specialpage/AuthManagerSpecialPage.php(353): MediaWiki\Auth\AuthManager->beginAuthentication(array, string)
  #11 /srv/mediawiki/php-1.30.0-wmf.4/includes/specialpage/AuthManagerSpecialPage.php(482): AuthManagerSpecialPage->performAuthenticationStep(string, array)
  #12 /srv/mediawiki/php-1.30.0-wmf.4/includes/htmlform/HTMLForm.php(663): AuthManagerSpecialPage->handleFormSubmit(array, VFormHTMLForm)
  #13 /srv/mediawiki/php-1.30.0-wmf.4/includes/specialpage/AuthManagerSpecialPage.php(416): HTMLForm->trySubmit()
  #14 /srv/mediawiki/php-1.30.0-wmf.4/includes/specialpage/LoginSignupSpecialPage.php(305): AuthManagerSpecialPage->trySubmit()
  #15 /srv/mediawiki/php-1.30.0-wmf.4/includes/specialpage/SpecialPage.php(522): LoginSignupSpecialPage->execute(NULL)
  #16 /srv/mediawiki/php-1.30.0-wmf.4/includes/specialpage/SpecialPageFactory.php(578): SpecialPage->run(NULL)
  #17 /srv/mediawiki/php-1.30.0-wmf.4/includes/MediaWiki.php(287): SpecialPageFactory::executePath(Title, RequestContext)
  #18 /srv/mediawiki/php-1.30.0-wmf.4/includes/MediaWiki.php(862): MediaWiki->performRequest()
  #19 /srv/mediawiki/php-1.30.0-wmf.4/includes/MediaWiki.php(523): MediaWiki->main()
  #20 /srv/mediawiki/php-1.30.0-wmf.4/index.php(43): MediaWiki->run()
  #21 /srv/mediawiki/w/index.php(3): include(string)
  #22 {main}

Details

SubjectRepoBranchLines +/-
Clean up debugging codemediawiki/extensions/LoginNotifymaster+3 -12
Use info itself instead of array indexmediawiki/extensions/LoginNotifymaster+10 -4
Add debug logging for DB connection errorsmediawiki/extensions/LoginNotifywmf/1.30.0-wmf.4+10 -2
Add debug logging for DB connection errorsmediawiki/extensions/LoginNotifymaster+10 -2
Customize query in gerrit

Related Objects

Event Timeline

MaxSem created this task.Jun 7 2017, 9:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 7 2017, 9:13 PM
Framawiki subscribed.Jun 7 2017, 10:17 PM
gerritbot subscribed.Jun 7 2017, 10:52 PM

Change 357737 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/LoginNotify@master] Add debug logging for DB connection errors

https://gerrit.wikimedia.org/r/357737

gerritbot added a project: Patch-For-Review.Jun 7 2017, 10:52 PM
MaxSem mentioned this in rELGN4b6b34a830bd: Add debug logging for DB connection errors.Jun 7 2017, 10:53 PM
gerritbot added a comment.Jun 8 2017, 12:24 AM

Change 357743 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/LoginNotify@wmf/1.30.0-wmf.4] Add debug logging for DB connection errors

https://gerrit.wikimedia.org/r/357743

MaxSem mentioned this in rELGNd52e6805f0f1: Add debug logging for DB connection errors.Jun 8 2017, 12:24 AM
gerritbot added a comment.Jun 8 2017, 12:26 AM

Change 357737 merged by jenkins-bot:
[mediawiki/extensions/LoginNotify@master] Add debug logging for DB connection errors

https://gerrit.wikimedia.org/r/357737

gerritbot added a comment.Jun 8 2017, 12:28 AM

Change 357743 merged by jenkins-bot:
[mediawiki/extensions/LoginNotify@wmf/1.30.0-wmf.4] Add debug logging for DB connection errors

https://gerrit.wikimedia.org/r/357743

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)).Jun 8 2017, 1:00 AM
Raymond subscribed.Jun 8 2017, 5:19 AM
gerritbot added a comment.Jun 10 2017, 12:03 AM

Change 358152 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/LoginNotify@master] Use info itself instead of array index

https://gerrit.wikimedia.org/r/358152

MaxSem mentioned this in rELGN483dc8730645: Use info itself instead of array index.Jun 10 2017, 12:05 AM
MaxSem mentioned this in rELGNdef0b00e197d: Use info itself instead of array index.Jun 10 2017, 12:13 AM
gerritbot added a comment.Jun 10 2017, 2:59 AM

Change 358152 merged by jenkins-bot:
[mediawiki/extensions/LoginNotify@master] Use info itself instead of array index

https://gerrit.wikimedia.org/r/358152

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)); removed MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)).Jun 10 2017, 3:00 AM
• DannyH moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Jun 13 2017, 10:27 PM
kaldari subscribed.Jun 13 2017, 11:23 PM

Latest patch needs to be tested on Test Wikipedia and then have the debugging code removed once we know it fixes the problem. If it doesn't fix the problem we need to implement a new fix.

kaldari triaged this task as High priority.Jun 13 2017, 11:26 PM
kaldari set the point value for this task to 5.
• DannyH moved this task from Needs Discussion to Up Next (June 3-21) on the Community-Tech board.Jun 13 2017, 11:28 PM
gerritbot added a comment.Jun 15 2017, 8:32 PM

Change 359246 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/LoginNotify@master] Clean up debugging code

https://gerrit.wikimedia.org/r/359246

MaxSem mentioned this in rELGN88f82fde100d: Clean up debugging code.Jun 15 2017, 8:37 PM
gerritbot added a comment.Jun 15 2017, 8:59 PM

Change 359246 merged by jenkins-bot:
[mediawiki/extensions/LoginNotify@master] Clean up debugging code

https://gerrit.wikimedia.org/r/359246

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)); removed MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)).Jun 15 2017, 9:00 PM
kaldari closed this task as Resolved.Jun 15 2017, 10:25 PM
kaldari claimed this task.
kaldari edited projects, added Community-Tech-Sprint; removed Community-Tech.
kaldari moved this task from Ready to Q1 2018-19 on the Community-Tech-Sprint board.

Fixed by https://gerrit.wikimedia.org/r/#/c/358152/. Debugging info cleaned up in https://gerrit.wikimedia.org/r/#/c/359246/.

kaldari reassigned this task from kaldari to MaxSem.Jun 15 2017, 10:27 PM
• DannyH edited projects, added Community-Tech; removed Community-Tech-Sprint.Jul 4 2017, 12:52 AM
• DannyH moved this task from Up Next (June 3-21) to Archive on the Community-Tech board.
MarcoAurelio moved this task from Backlog to Done on the MediaWiki-extensions-LoginNotify board.Aug 28 2017, 8:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits