Ensure all variables sent to process template are defined.
Closed, ResolvedPublic

Description

We previously had a fatal error make it to deploy train because one of the variables sent to processTemplate was undefined: T161735

We need to patch https://gerrit.wikimedia.org/r/#/c/339941/ to make sure that doesn't happen with that one before it gets deployed (Thurs). Mustache can handle undefined variables but it appears that processTemplate cannot.

It would probably be good just to define all the variables at the top of the file that are getting to processTemplate to ensure they're all defined.

Mvolz created this task.Jun 11 2017, 6:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 11 2017, 6:28 AM
Mvolz triaged this task as Unbreak Now! priority.Jun 11 2017, 6:28 AM
Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptJun 11 2017, 6:28 AM

Change 358228 had a related patch set uploaded (by Harjotsingh; owner: Harjotsingh):
[mediawiki/extensions/Quiz@master] Define all variables that are sent to process tepmlate

https://gerrit.wikimedia.org/r/358228

Change 358228 merged by jenkins-bot:
[mediawiki/extensions/Quiz@master] Define all variables that are sent to process tepmlate

https://gerrit.wikimedia.org/r/358228

Harjotsingh closed this task as Resolved.Jun 14 2017, 12:30 PM

Change merged