Page MenuHomePhabricator

Deduplicate the gateways in RelatedArticles
Closed, ResolvedPublic2 Estimated Story Points

Description

RelatedArticles is not using the [CardsGateway](https://github.com/wikimedia/mediawiki-extensions-RelatedArticles/blob/master/resources/ext.relatedArticles.cards/CardsGateway.js), instead it reimplemented a [RelatedPagesGateway](https://github.com/wikimedia/mediawiki-extensions-RelatedArticles/blob/master/resources/ext.relatedArticles.readMore.gateway/RelatedPagesGateway.js).

That means that we've been shipping extra unused code, so we should de-duplicate the gateways and keep one.

See related report T137021: Reduce Cards confusion by merging it into RelatedArticles extension (of cards gateway not working that lead to merging cards with relatedarticles).

AC

  • There is only one gateway implementation on RelatedArticles
  • No extra/unused code is bundled to the client
  • Documentation doesn't mention CardsGateway

Event Timeline

Jdlrobson triaged this task as Medium priority.Jun 12 2017, 3:46 PM
Jdlrobson moved this task from Incoming to Triaged but Future on the Readers-Web-Backlog board.
ovasileva set the point value for this task to 2.Jun 13 2017, 4:43 PM

Change 359031 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/RelatedArticles@master] Remove CardsGateway (unused)

https://gerrit.wikimedia.org/r/359031

Change 359031 merged by jenkins-bot:
[mediawiki/extensions/RelatedArticles@master] Remove CardsGateway (unused)

https://gerrit.wikimedia.org/r/359031

@pmiazga the cards extension is being emptied as part of the undeploy. It's taken care of by https://gerrit.wikimedia.org/r/#/c/359048/ (part of T167452)

@Jdlrobson sure, but the T167452 doesn't state that we should remove this repo from Github. If Github repo stays we should fix the readme.

Everything looks good, I'm resolving this task.