Page MenuHomePhabricator
Create Task
Maniphest T167647

Deduplicate the gateways in RelatedArticles
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

RelatedArticles is not using the [CardsGateway](https://github.com/wikimedia/mediawiki-extensions-RelatedArticles/blob/master/resources/ext.relatedArticles.cards/CardsGateway.js), instead it reimplemented a [RelatedPagesGateway](https://github.com/wikimedia/mediawiki-extensions-RelatedArticles/blob/master/resources/ext.relatedArticles.readMore.gateway/RelatedPagesGateway.js).

That means that we've been shipping extra unused code, so we should de-duplicate the gateways and keep one.

See related report T137021: Reduce Cards confusion by merging it into RelatedArticles extension (of cards gateway not working that lead to merging cards with relatedarticles).

AC

  • There is only one gateway implementation on RelatedArticles
  • No extra/unused code is bundled to the client
  • Documentation doesn't mention CardsGateway

Details

SubjectRepoBranchLines +/-
Remove CardsGateway (unused)mediawiki/extensions/RelatedArticlesmaster+1 -231
Customize query in gerrit

Related Objects

Event Timeline

• Jhernandez created this task.Jun 12 2017, 9:45 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 12 2017, 9:45 AM
• Jhernandez mentioned this in T137021: Reduce Cards confusion by merging it into RelatedArticles extension.Jun 12 2017, 9:46 AM
Jdlrobson triaged this task as Medium priority.Jun 12 2017, 3:46 PM
Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.
Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Jun 12 2017, 6:34 PM
ovasileva set the point value for this task to 2.Jun 13 2017, 4:43 PM
Jdlrobson moved this task from Upcoming to 2016-17 Q4 on the Web-Team-Backlog board.Jun 14 2017, 3:57 AM
Jdlrobson added a project: Readers-Web-Kanbanana-Board-Old.
ovasileva moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Jun 14 2017, 5:36 PM
Jdlrobson moved this task from Needs Design Review to Doing on the Readers-Web-Kanbanana-Board-Old board.Jun 14 2017, 8:07 PM
gerritbot subscribed.Jun 14 2017, 8:11 PM

Change 359031 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/RelatedArticles@master] Remove CardsGateway (unused)

https://gerrit.wikimedia.org/r/359031

gerritbot added a project: Patch-For-Review.Jun 14 2017, 8:11 PM
Jdlrobson claimed this task.Jun 14 2017, 8:11 PM
Jdlrobson moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.
• bmansurov moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Jun 14 2017, 9:21 PM
gerritbot added a comment.Jun 14 2017, 9:26 PM

Change 359031 merged by jenkins-bot:
[mediawiki/extensions/RelatedArticles@master] Remove CardsGateway (unused)

https://gerrit.wikimedia.org/r/359031

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)).Jun 14 2017, 10:00 PM
pmiazga removed a project: Patch-For-Review.Jun 15 2017, 6:25 PM
pmiazga moved this task from Ready for Signoff to Needs More Work on the Readers-Web-Kanbanana-Board-Old board.
pmiazga subscribed.

Please update Cards documentation. README.md still mentions CardsGateway class: https://github.com/wikimedia/mediawiki-extensions-Cards/blob/master/README.md

pmiazga updated the task description. (Show Details)Jun 15 2017, 6:27 PM
Jdlrobson moved this task from Needs More Work to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Jun 16 2017, 4:35 PM

@pmiazga the cards extension is being emptied as part of the undeploy. It's taken care of by https://gerrit.wikimedia.org/r/#/c/359048/ (part of T167452)

pmiazga added a comment.Jun 16 2017, 5:32 PM

@Jdlrobson sure, but the T167452 doesn't state that we should remove this repo from Github. If Github repo stays we should fix the readme.

pmiazga added a comment.Jun 16 2017, 6:14 PM

Everything looks good, I'm resolving this task.

pmiazga closed this task as Resolved.Jun 16 2017, 6:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits