Page MenuHomePhabricator

Thanks says "received your thanks", but there is no way to know
Closed, ResolvedPublic

Description

Some thanks confirmations (on mobile and desktop) say "ABC received your thanks" when you send thanks.

(I saw this in production, and both thanks-thanked-notice and flow-thanks-thanked-notice have this text).

Whether the target receives your thanks is private information, determined by the Thanks notification preference. So this statement can be inaccurate.

It should just say you sent it/thanked them, similar to e.g. notification-header-mention-success:

"{{GENDER:$2|Your}} mention of <strong>$3</strong> was sent."

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Mattflaschen-WMF renamed this task from Mobile thanks says "received your thanks", but there is no way to know to Thanks says "received your thanks", but there is no way to know.Jun 21 2017, 11:24 PM

Change 360785 had a related patch set uploaded (by Mattflaschen; owner: Mattflaschen):
[mediawiki/extensions/Thanks@master] Fix Thanks messages not say "received your thanks"

https://gerrit.wikimedia.org/r/360785

@jmatazzoni

Current patch has:

You thanked Abc for his/her/their edit.

(with the gender and username substituted in)

and similarly for Flow:

You thanked Abc for his/her/their comment.

I'll remove my -1 when you approve text (above or a new replacement).

Change 360785 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Fix Thanks messages not say "received your thanks"

https://gerrit.wikimedia.org/r/360785

I'll remove my -1 when you approve text (above or a new replacement).

Sorry, it got merged by accident. I should have -2'ed it. However, we can do a followup if you want to change the text.

Checked in betalabs mobile.
The following text is implemented:

{{GENDER:$3|You}} thanked $1 for {{GENDER:$2|his|her|their}} edit."

IMG_2938.PNG (1×640 px, 103 KB)

IMG_2939.PNG (1×640 px, 104 KB)

@jmatazzoni - please verify that the wording is ok as per @Mattflaschen-WMF comment.

QA Recommendation: Product should weigh in