Page MenuHomePhabricator
Create Task
Maniphest T169273

[betalabs-regression] RC page - blank names for filter selection can be saved
Closed, ResolvedPublic
Actions

Description

The issue is not present in wmf.7 - the attempt to save a blank name will display a red outline indicating invalid input.

  1. On RC page with filters enabled and several filters selected, click on the bookmark icon and press the spacebar several times to enter white spaces as a filter name.
  2. 'Create filter' button is active and can be clicked to save the filter selection with a blank name.
  3. Rename any filter by entering white spaces as a name - the issue is present in production.
  4. The Saved filters will display blank names:

Screen Shot 2017-06-29 at 3.00.37 PM.png (352×358 px, 15 KB)

Details

SubjectRepoBranchLines +/-
RCFilters: Trim spaces in saved query namesmediawiki/coremaster+38 -20
Customize query in gerrit

Event Timeline

Etonkovidova created this task.Jun 29 2017, 10:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 29 2017, 10:03 PM
Etonkovidova renamed this task from [betalabs-regression] Filters with blank names can be saved to [betalabs-regression] RC page - blank names for filter selection can be saved.Jun 29 2017, 10:05 PM
Mooeypoo subscribed.Jun 30 2017, 12:29 AM

This shouldn't happen anymore, can you re-check? The "Apply" button should be disabled when the text is empty, and the saved query shouldn't be saved at all if there's nothing in the input, including when you press enter.

Etonkovidova added a comment.Jun 30 2017, 4:37 PM

@Mooeypoo Re-checked -the issue is still present in betalabs.

gerritbot subscribed.Jun 30 2017, 4:50 PM

Change 362436 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Trim spaces in saved query names

https://gerrit.wikimedia.org/r/362436

gerritbot added a project: Patch-For-Review.Jun 30 2017, 4:50 PM
Mooeypoo claimed this task.Jun 30 2017, 4:50 PM
Mooeypoo moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.

Oy, sorry, when we changed the way validation works, I removed the condition to treat spaces as empty.
Fixed in the commit above.

Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.Jun 30 2017, 10:08 PM
gerritbot added a comment.Jun 30 2017, 10:20 PM

Change 362436 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Trim spaces in saved query names

https://gerrit.wikimedia.org/r/362436

Etonkovidova added a comment.Jul 3 2017, 8:39 PM

Checked the fix in betalabs - empty filter names (either as new ones or via renaming) cannot be saved anymore.

Etonkovidova closed this task as Resolved.Jul 3 2017, 8:39 PM
Etonkovidova triaged this task as Low priority.
ReleaseTaggerBot added a project: MW-1.30-release-notes.Jul 8 2017, 1:17 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL