I just waitlisted an application on staging, and the email I received started "Dear 47183485...", but should have addressed me with my name / username.
Adding this as a migration blocker - hopefully not too difficult a fix?
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | jsn.sherman | T147434 Version 1.5: Beta fixes | |||
| Resolved | Samwalton9-WMF | T151177 Migrate users from signup sheets to the Library Card Platform | |||
| Invalid | None | T170977 Post-migration issues and priorities | |||
| Resolved | jsn.sherman | T169525 Emails to users should address them with their username, not their ID |
Event Timeline
Comment Actions
Because this touches on the model for applications, with their dynamic fields and revision system it turned out to be more complicated than I hoped.
My first attempt at this has been pushed to staging. I was able to test that this is correct for messages for the applicant's on import, but we need to make sure it doesn't mix up coordinator vs applicant usernames on messages from actual application transactions. Please test on staging.
Comment Actions
I found and fixed (on staging) a related display bug on the application review displays. We were getting the numerical ID's for the "last reviewed by" information. It's now displaying the appropriate wp username.
Comment Actions
And while working on that display bug, I found that I *was* using the wrong selector for the salutation in the email. We're now getting the wp_username for the same user object for whom we were previously printing a numerical id. That's not to say that I've verified that it's correct, just that I haven't broken it in a new way. I'd call this production ready since I've verified that we've fixed this issue in the narrowest of terms.
Comment Actions
Great, will keep an eye on sent emails to verify.
Not sure the 2nd bug is fixed though - https://wikipedialibrary.wmflabs.org/applications/evaluate/125/ still says "Reviewed by 4951298".
Comment Actions
Ah, good catch. Each place (review applications list, application details, each application related email) uses its own template, and the references have to be changed per-template. The email templates have all been updated as has the template for the list of applications. Looks like I still need to get the template for the application details page.
Comment Actions
Verified that emails appear to be going out correctly now. I'll leave this task open for now as a reminder to fix the related applications details issue.