Page MenuHomePhabricator

tools-redis command "SCAN" can be used to find keys
Closed, ResolvedPublic

Event Timeline

From https://wikitech.wikimedia.org/wiki/Help:Tool_Labs#Redis:
"We have also disabled the redis commands that let users 'list' keys.", so this is likely an oversight. It looks like this can be corrected in modules/toollabs/manifests/redis.pp by renaming the command.

so this is likely an oversight.

Whack-a-mole :(

This command was added in 2.8.0, which was released around 22-Nov-2013, after the list was compiled on Jun 25, 2013

It looks like this can be corrected in modules/toollabs/manifests/redis.pp by renaming the command.

Yeah that's surely the easiest solution.

chasemp triaged this task as Medium priority.

Fixed with https://gerrit.wikimedia.org/r/#/c/363858/

bd808@tools-redis-1001:~$ redis-cli
127.0.0.1:6379> SCAN
(error) ERR unknown command 'SCAN'
127.0.0.1:6379>
bd808 changed the visibility from "Custom Policy" to "Public (No Login Required)".
bd808 moved this task from Inbox to Done on the cloud-services-team (Kanban) board.