Page MenuHomePhabricator

[betalabs-regression] Enhanced RC displays misaligned timestamps in a smaller font
Closed, ResolvedPublic

Description

On betalabs RC page with enabled 'Enhanced recent changes' option will display

  • the timestamp for grouped edits misaligned
  • a smaller font for the timestamp and the legend letters

Screen Shot 2017-07-07 at 11.48.43 AM.png (546×1 px, 174 KB)

For comparison - testwiki (the same scale):

Screen Shot 2017-07-07 at 11.33.53 AM.png (560×837 px, 221 KB)

Event Timeline

Catrope subscribed.

The way it looks on beta is what it's "supposed" to look like, (the smaller font size appears to be because of font-family: monospace), the way it looks on testwiki is caused by the WatchlistGreenIndicators gadget. Disabling the gadget (https://test.wikipedia.org/w/index.php?title=Special:RecentChanges&enhanced=1&safemode=1) causes testwiki to look the same as beta.

That said, I think we should put this fix in core. There's this strange behavior in CSS That I don't understand (both Chrome and Firefox behave the same, so probably not a browser bug) where font-family: monospace causes the font size to be smaller, but font-size: monospace, monospace doesn't for some reason.

Current state (Chrome):

rc-monospace.png (200×693 px, 68 KB)

Current state (Firefox):

rc-monospace-ff.png (202×767 px, 55 KB)

With patch (Chrome):

rc-monospace-twice.png (200×716 px, 69 KB)

With patch (Firefox):

rc-monospace-twice-ff.png (207×783 px, 56 KB)

Change 363872 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] Fix font size / alignment of timestamps in enhanced recent changes

https://gerrit.wikimedia.org/r/363872

Change 363872 merged by jenkins-bot:
[mediawiki/core@master] Fix font size / alignment of timestamps in enhanced recent changes

https://gerrit.wikimedia.org/r/363872

The fix is checked in betalabs - looks good:

Screen Shot 2017-07-11 at 3.42.51 PM.png (299×985 px, 122 KB)

QA Recommendation: Resolve