Editor does not show confirmation that an edit was successful
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

A key browser test is currently failing:
Scenario: Successful edit on page without languages shows no language button [bug 63675]

This blocks all merges to MobileFrontend as well as daily integration browser tests:
https://integration.wikimedia.org/ci/view/Reading-Web/job/selenium-MobileFrontend/484/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/testReport/junit/(root)/Wikitext%20Editor%20(Makes%20actual%20saves)/Successful_edit_on_page_without_languages_shows_no_language_button__bug_63675_/

Replication steps

Visit any page and click edit icon on beta cluster e.g. https://en.m.wikipedia.beta.wmflabs.org/wiki/Headings
Go through edit dialog and hit save
Expected: a notification shows saying "Success! Your edit was saved."
Actual: Nothing happens

Any edit to the mobile site, does not appear to be giving the user feedback that the edit was successful.

Details

	Subject	Repo	Branch	Lines +/-
	QA: Fix flakey tests by adding additional steps	mediawiki/extensions/MobileFrontend	master	+3 -1

Customize query in gerrit

Related Objects

Mentioned In: T168758: Migrate browser tests to Minerva from MobileFrontend

Event Timeline

Jdlrobson created this task.Jul 10 2017, 8:40 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 10 2017, 8:40 PM

Jdlrobson triaged this task as Unbreak Now! priority.Jul 10 2017, 8:40 PM

Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptJul 10 2017, 8:40 PM

Jdlrobson moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Jul 10 2017, 8:41 PM

Jdlrobson updated the task description. (Show Details)Jul 10 2017, 9:15 PM

What seems to be happening is the page refresh query is getting stalled by Chrome.

Screen Shot 2017-07-10 at 2.17.39 PM.png (429×692 px, 68 KB)

I can't replicate this locally. Did anything change in VisualEditor recently that might be cancelling this request?

Jdlrobson mentioned this in T168758: Migrate browser tests to Minerva from MobileFrontend.Jul 10 2017, 9:42 PM

This doesn't seem to happen all the time on the beta cluster... I've seen a few Selenium builds pass.

This seems to be a flakey test as I just managed to merge a patch.. so this is only frustrating in that we can't merge code easily so dropping down from UBN status.

Change 364348 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] QA: Fix flakey test by adding an additional step

https://gerrit.wikimedia.org/r/364348

gerritbot added a project: Patch-For-Review.Jul 11 2017, 12:14 AM

Jdlrobson moved this task from Needs Design Review to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jul 11 2017, 12:15 AM

Change 364348 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] QA: Fix flakey tests by adding additional steps

https://gerrit.wikimedia.org/r/364348

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)).Jul 11 2017, 4:00 PM

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Jul 11 2017, 5:03 PM

• Deskana moved this task from To Triage to External and Administrivia on the VisualEditor board.Jul 11 2017, 7:14 PM

Build is green again: https://integration.wikimedia.org/ci/view/Reading-Web/job/selenium-MobileFrontend/
This was a flakey test.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 11 2017, 10:09 PM

Jdforrester-WMF set the point value for this task to 0.Jul 14 2017, 11:20 PM

	F8696185: Screen Shot 2017-07-10 at 2.17.39 PM.png
	Jul 10 2017, 9:18 PM

Editor does not show confirmation that an edit was successfulClosed, ResolvedPublic0 Estimated Story PointsActions