Page MenuHomePhabricator

Find way to exclude php 5.4 files from vendor lint task
Closed, ResolvedPublic

Description

Our vendor lint task falls over on
23:55:07 PHP Fatal error: Cannot redeclare class CallbackFilterIterator in symfony/polyfill-php54/Resources/stubs/CallbackFilterIterator.php on line 28
23:55:07 Errors parsing symfony/polyfill-php54/Resources/stubs/CallbackFilterIterator.php

I spoke to Casey about excluding & he came up with

"It doesn't look like there is any proper functionality in that script to
ignore files, just:

https://github.com/wikimedia/integration-jenkins/blob/master/bin/git-changed-in-head#L73-L74

Tyler said he'd rather generalize that (another script to filter the
checked files) than add another case.

I thought you could just delete the files, but I would understand if
that sounds like a maintenance headache.

Let me know what you think!"

I suspect the best answer is to try to get ? Tyler ? to change the script such that we can put a file containing names of files to skip in the committed directory