Page MenuHomePhabricator
Create Task
Maniphest T173083

Link to Special:MultiLock on Special:CheckUser "get users" display is broken when there is a "&" char in a selected username
Closed, ResolvedPublic
Actions

Description

Link to Special:MultiLock on Special:CheckUser "get users" display is broken when there is a "&" char in a selected username.
The list in Special:MultiLock is partially generated and it ends with the part of the username before the "&" char.

Details

SubjectRepoBranchLines +/-
Use encodeURIComponent to encode usernames with special charsmediawiki/extensions/CheckUsermaster+1 -1
Customize query in gerrit

Event Timeline

Melos created this task.Aug 11 2017, 12:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 11 2017, 12:18 PM
Melos triaged this task as Medium priority.Aug 11 2017, 12:20 PM
Melos updated the task description. (Show Details)
MarcoAurelio added subscribers: Glaisher, Legoktm.Aug 11 2017, 3:30 PM
gerritbot subscribed.Aug 12 2017, 5:12 PM

Change 371631 had a related patch set uploaded (by Melos; owner: Melos):
[mediawiki/extensions/CheckUser@master] Bug: T173083 Use encodeURIComponent to encode usernames with special chars.

https://gerrit.wikimedia.org/r/371631

gerritbot added a project: Patch-For-Review.Aug 12 2017, 5:12 PM
gerritbot added a comment.Aug 12 2017, 7:48 PM

Change 371631 had a related patch set uploaded (by MarcoAurelio; owner: Melos):
[mediawiki/extensions/CheckUser@master] Use encodeURIComponent to encode usernames with special chars

https://gerrit.wikimedia.org/r/371631

gerritbot added a comment.Aug 12 2017, 8:16 PM

Change 371631 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Use encodeURIComponent to encode usernames with special chars

https://gerrit.wikimedia.org/r/371631

Melos closed this task as Resolved.Aug 12 2017, 8:26 PM
Melos claimed this task.
MarcoAurelio added subscribers: Krenair, MarcoAurelio.Aug 12 2017, 8:30 PM

Thanks @Melos for the fix and @Krenair for your code-review.

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)).Aug 21 2017, 5:02 PM
MarcoAurelio moved this task from Inbox to Done on the CheckUser board.Aug 28 2017, 1:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits