Add sniff to prefer short is_int over is_integer
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	Aug 12 2017, 12:21 PM

Description

With T145162 the parameter documentation should be forced to use int / bool

This should than also be done for the is_integer function. It should use is_int instead.

It seems a is_boolean function does not exists.

Negative test cases:

$this->is_integer( $var )
self::is_integer( $var )

Details

	Subject	Repo	Branch	Lines +/-
	Add sniff for using is_int over is_integer	mediawiki/tools/codesniffer	master	+104 -0

Customize query in gerrit

Related Objects

Mentioned In: T183220: Add PHPCS rule to autofix some aliased PHP function names for consistency
Mentioned Here: T145162: Provide Codesniffer rules to enforce "short" type definitions (int/bool, not integer/boolean)

Event Timeline

Umherirrender created this task.Aug 12 2017, 12:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 12 2017, 12:21 PM

Umherirrender renamed this task from Add sniff to prefereshort is_int over is_integer to Add sniff to prefer short is_int over is_integer.Aug 12 2017, 12:21 PM

Legoktm moved this task from Untriaged to Accepted rule changes on the MediaWiki-Codesniffer board.Sep 8 2017, 5:45 PM

Change 398677 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/tools/codesniffer@master] Add sniff for using is_int over is_integer

https://gerrit.wikimedia.org/r/398677

gerritbot added a project: Patch-For-Review.Dec 17 2017, 6:38 AM

Legoktm claimed this task.Dec 17 2017, 6:41 AM

Legoktm moved this task from Accepted rule changes to In progress on the MediaWiki-Codesniffer board.Dec 17 2017, 8:07 AM

Ricordisamoa updated the task description. (Show Details)Dec 17 2017, 7:24 PM

Ricordisamoa subscribed.

Legoktm mentioned this in T183220: Add PHPCS rule to autofix some aliased PHP function names for consistency.Dec 19 2017, 6:56 AM

Change 398677 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Add sniff for using is_int over is_integer

https://gerrit.wikimedia.org/r/398677

Ricordisamoa removed a project: Patch-For-Review.Dec 19 2017, 6:38 PM

Legoktm closed this task as Resolved.Dec 19 2017, 11:04 PM