Page MenuHomePhabricator
Create Task
Maniphest T173335

CookieWarning overlaps personal tools
Closed, ResolvedPublic
Actions

Description

When opening a site with CookieWarning enabled, the bar will be shown as:

image.png (55×1 px, 17 KB)

The problem is, that the user, if not logged in, has first to click "Okay" to login. This, from my point of view, is bad design. There's probably a better way of displaying the warning, e.g. like this without having 100% width? This however does only work, if the message is not long enough:

image.png (52×1 px, 17 KB)

There may be better options as well, and I would like to read some ideas :D

Details

SubjectRepoBranchLines +/-
Move the warning outside sitenotice, tidy up codemediawiki/extensions/CookieWarningREL1_35+127 -218
Move the warning outside sitenotice, tidy up codemediawiki/extensions/CookieWarningmaster+127 -218
Customize query in gerrit

Related Objects

Event Timeline

Florian created this task.Aug 14 2017, 5:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 14 2017, 5:28 PM
gerritbot added a comment.Feb 1 2021, 9:55 AM

Change 660775 had a related patch set uploaded (by Ostrzyciel; owner: Ostrzyciel):
[mediawiki/extensions/CookieWarning@master] Move the warning outside sitenotice, tidy up code

https://gerrit.wikimedia.org/r/660775

gerritbot added a project: Patch-For-Review.Feb 1 2021, 9:55 AM
Ostrzyciel subscribed.Feb 1 2021, 10:22 AM
Kizule moved this task from Incoming to For Review on the Design board.Feb 1 2021, 5:43 PM
gerritbot added a comment.Feb 1 2021, 5:44 PM

Change 660775 merged by jenkins-bot:
[mediawiki/extensions/CookieWarning@master] Move the warning outside sitenotice, tidy up code

https://gerrit.wikimedia.org/r/660775

Ostrzyciel closed this task as Resolved.Feb 1 2021, 5:45 PM
Ostrzyciel claimed this task.
Ostrzyciel moved this task from For Review to Done on the Design board.
gerritbot added a comment.Feb 1 2021, 5:56 PM

Change 660803 had a related patch set uploaded (by Paladox; owner: Ostrzyciel):
[mediawiki/extensions/CookieWarning@REL1_35] Move the warning outside sitenotice, tidy up code

https://gerrit.wikimedia.org/r/660803

gerritbot added a comment.Feb 1 2021, 6:07 PM

Change 660803 merged by Jack Phoenix:
[mediawiki/extensions/CookieWarning@REL1_35] Move the warning outside sitenotice, tidy up code

https://gerrit.wikimedia.org/r/660803

Maintenance_bot removed a project: Patch-For-Review.Feb 1 2021, 6:10 PM
Paladox mentioned this in rECW4f3981580db3: Move the warning outside sitenotice, tidy up code.Feb 1 2021, 6:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL