Page MenuHomePhabricator

Ostrzyciel (Ostrzyciel)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 30 2019, 10:45 PM (61 w, 1 d)
Availability
Available
IRC Nick
Ostrzyciel
LDAP User
Unknown
MediaWiki User
Ostrzyciel [ Global Accounts ]

Recent Activity

Sat, May 30

Ostrzyciel closed T252366: Choose the definition of a "reverted" edit, a subtask of T254074: Implement the reverted edit tag, as Resolved.
Sat, May 30, 5:27 PM · MediaWiki-Page-editing
Ostrzyciel closed T252366: Choose the definition of a "reverted" edit as Resolved.

I think I'll wrap it up here, I got some very useful feedback and had plenty of time to think it over. :) I collected the conclusions in T254074: Implement the reverted edit tag and will start implementing this soon, probably.

Sat, May 30, 5:27 PM · Growth-Team, MediaWiki-Revision-backend, MediaWiki-Page-editing, Notifications
Ostrzyciel removed a subtask for T248775: Proposal: Add Reverted filter to RecentChanges Filters: T252366: Choose the definition of a "reverted" edit.
Sat, May 30, 5:24 PM · Google-Summer-of-Code (2020)
Ostrzyciel added a subtask for T254074: Implement the reverted edit tag: T252366: Choose the definition of a "reverted" edit.
Sat, May 30, 5:24 PM · MediaWiki-Page-editing
Ostrzyciel edited parent tasks for T252366: Choose the definition of a "reverted" edit, added: T254074: Implement the reverted edit tag; removed: T248775: Proposal: Add Reverted filter to RecentChanges Filters.
Sat, May 30, 5:24 PM · Growth-Team, MediaWiki-Revision-backend, MediaWiki-Page-editing, Notifications
Ostrzyciel created T254074: Implement the reverted edit tag.
Sat, May 30, 5:23 PM · MediaWiki-Page-editing

Fri, May 29

Ostrzyciel updated the task description for T252366: Choose the definition of a "reverted" edit.
Fri, May 29, 9:36 AM · Growth-Team, MediaWiki-Revision-backend, MediaWiki-Page-editing, Notifications

Sat, May 23

Ostrzyciel updated subscribers of T253371: Enhanced RC on Timeless with MF does not show expansion arrows.

It turns out Minerva disables enhanced RC altogether through a hook: https://gerrit.wikimedia.org/g/mediawiki/skins/MinervaNeue/+/0c488fa4f775815e96a64924c6b24ecd128a4b1b/includes/MinervaHooks.php#71

Sat, May 23, 2:59 PM · MobileFrontend, Timeless

Fri, May 22

Ostrzyciel added a comment to T253370: MobileFrontend collapsible sections look bad on Timeless.

After some messing with CSS I think there's something wrong with Timeless's styles for OOUI icons, from what I see Minerva does them quite differently. I'm not sure how to fix this, though, OOUI's CSS scares me.

Fri, May 22, 7:03 PM · MobileFrontend, Timeless
Ostrzyciel added a comment to T181321: Mobile rules to keep images from overflowing (due to small screens) mess up templates.

It may a bad idea though, we will see if we run into some problems because of that :P

Fri, May 22, 10:52 AM · Timeless
Ostrzyciel created T253371: Enhanced RC on Timeless with MF does not show expansion arrows.
Fri, May 22, 7:09 AM · MobileFrontend, Timeless
Ostrzyciel added a comment to T231246: Collapse sections on small screens on long pages.

Note that this already works fine with MF, and probably belongs in core...

Fri, May 22, 6:09 AM · Timeless
Ostrzyciel created T253370: MobileFrontend collapsible sections look bad on Timeless.
Fri, May 22, 6:01 AM · MobileFrontend, Timeless
Ostrzyciel added a comment to T181321: Mobile rules to keep images from overflowing (due to small screens) mess up templates.

We had a similar issue with that CSS rule in this template, the icon was disappearing on narrow displays. We tried to find places where this rule is actually helpful for us, but we couldn't find any, so we disabled it completely.

Fri, May 22, 5:51 AM · Timeless

Thu, May 21

Ostrzyciel added a comment to T252366: Choose the definition of a "reverted" edit.

My first reaction to this is that we shouldn't say that a "revert edit" is a judgment about good or bad, just a reversion of text to a previous version. So I don't think this is something to worry about, personally.

Thu, May 21, 3:27 PM · Growth-Team, MediaWiki-Revision-backend, MediaWiki-Page-editing, Notifications
Ostrzyciel added a comment to T252366: Choose the definition of a "reverted" edit.

I thought a bit about revert wars and how would this feature work with them. Suppose we have a series of edits, in chronological order:

  1. User Alice
  2. User Bob
  3. User Alice, reverts to version 1
  4. User Bob, reverts to version 2
  5. User Alice, reverts to version 1
  6. User Bob, reverts to version 2
Thu, May 21, 7:55 AM · Growth-Team, MediaWiki-Revision-backend, MediaWiki-Page-editing, Notifications

Wed, May 20

Ostrzyciel added a comment to T117754: Convert Special:WhatLinksHere to OOUI.

This is not directly related to the task, but I thought some of this may be useful to someone. I'm the maintainer of the AdvancedBacklinks extensions that lets you track links through transclusions and can get you easily in a psychiatric hospital. Anyway, this extension has a special page very similar to Special:WhatLinksHere, just enhanced with a few neat features. I recently rewrote some of this special page to use OOUI and the end result is this:

Wed, May 20, 4:20 PM · Readers-Web-Backlog (Tracking), Advanced Mobile Contributions, MediaWiki-Special-pages, Design, UI-Standardization
Ostrzyciel added a comment to T252366: Choose the definition of a "reverted" edit.

Thank you @nettrom_WMF, that research paper is indeed very good. It also led me to thinking of cases when a reverted edit is reverted back, that would have to be handled nicely. I will have to think this through carefully, as I can think of many weird cases that would be tricky to solve, i.e. what happens if there is a revert war longer than 15 edits. This also leads me to think implementing this can require something more complicated than just a revision tag.

Wed, May 20, 8:38 AM · Growth-Team, MediaWiki-Revision-backend, MediaWiki-Page-editing, Notifications

Tue, May 12

Ostrzyciel created T252518: Add hook to Linker::generateRollback().
Tue, May 12, 10:03 AM · Patch-For-Review, MediaWiki-Core-Hooks, MediaWiki-Interface

Mon, May 11

Ostrzyciel added a subtask for T248775: Proposal: Add Reverted filter to RecentChanges Filters: T252366: Choose the definition of a "reverted" edit.
Mon, May 11, 7:21 AM · Google-Summer-of-Code (2020)
Ostrzyciel added a parent task for T252366: Choose the definition of a "reverted" edit: T248775: Proposal: Add Reverted filter to RecentChanges Filters.
Mon, May 11, 7:21 AM · Growth-Team, MediaWiki-Revision-backend, MediaWiki-Page-editing, Notifications
Ostrzyciel created T252366: Choose the definition of a "reverted" edit.
Mon, May 11, 7:18 AM · Growth-Team, MediaWiki-Revision-backend, MediaWiki-Page-editing, Notifications

Mar 30 2020

Ostrzyciel updated the task description for T248775: Proposal: Add Reverted filter to RecentChanges Filters.
Mar 30 2020, 4:40 PM · Google-Summer-of-Code (2020)
Ostrzyciel committed rELIWf1c9171b8f4d: Remove the use of OutputPage::addWikitext() (authored by Ostrzyciel).
Remove the use of OutputPage::addWikitext()
Mar 30 2020, 10:54 AM
Ostrzyciel closed T248826: Deleting page fails on 1.34: undefined method OutputPage::addWikiText() as Resolved.
Mar 30 2020, 10:08 AM · MediaWiki-extensions-LinkedWiki
Ostrzyciel created T248826: Deleting page fails on 1.34: undefined method OutputPage::addWikiText().
Mar 30 2020, 9:01 AM · MediaWiki-extensions-LinkedWiki

Mar 29 2020

Ostrzyciel created T248775: Proposal: Add Reverted filter to RecentChanges Filters.
Mar 29 2020, 8:20 AM · Google-Summer-of-Code (2020)

Mar 28 2020

Ostrzyciel updated the task description for T247406: Proposal: InstantCommons improvements.
Mar 28 2020, 9:24 AM · Google-Summer-of-Code (2020)
Ostrzyciel closed T247406: Proposal: InstantCommons improvements as Declined.

I am forced to abandon this proposal, as there was nobody willing to mentor this project.

Mar 28 2020, 9:23 AM · Google-Summer-of-Code (2020)

Mar 26 2020

Ostrzyciel added a comment to T247406: Proposal: InstantCommons improvements.

The current plan is to pursue switching over everything to Parsoid on the Wikimedia cluster in the 15-18 month timeframe -- or at least pursue that timeline and see where we land.

Mar 26 2020, 4:00 PM · Google-Summer-of-Code (2020)

Mar 17 2020

Ostrzyciel updated the task description for T247406: Proposal: InstantCommons improvements.
Mar 17 2020, 10:50 AM · Google-Summer-of-Code (2020)

Mar 12 2020

Ostrzyciel updated the task description for T247406: Proposal: InstantCommons improvements.
Mar 12 2020, 8:50 PM · Google-Summer-of-Code (2020)

Mar 11 2020

Aklapper renamed Ostrzyciel from Magwac to Ostrzyciel.
Mar 11 2020, 12:57 PM
Ostrzyciel updated subscribers of T247406: Proposal: InstantCommons improvements.

I am not sure if the above proposal is sensible or not in technical terms and some feedback from people that know these modules well would be much appreciated :) I am also looking for people willing to mentor this project.
I contacted @srishakatux before regarding this project and she recommended me to ask a few people regarding that, so I'm tagging them here.
@ssastry @cscott @Anomie @cicalese

Mar 11 2020, 12:47 PM · Google-Summer-of-Code (2020)
Ostrzyciel created T247406: Proposal: InstantCommons improvements.
Mar 11 2020, 12:43 PM · Google-Summer-of-Code (2020)
Ostrzyciel closed T228579: Make link to all categories configurable as Resolved.
Mar 11 2020, 10:46 AM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Multimedia, UploadWizard

Mar 9 2020

Ostrzyciel removed a watcher for UploadWizard: Ostrzyciel.
Mar 9 2020, 6:10 PM

Feb 25 2020

Ostrzyciel added a comment to T246127: updateCollation.php throws an error.

Did you mean REL1_33? I looked and it seems like 8f666cabcdcda75fa9cfe2409444861cccb36877 only came in in REL1_34

Feb 25 2020, 5:28 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), MW-1.34-notes, MediaWiki-Maintenance-system
Ostrzyciel updated the task description for T246127: updateCollation.php throws an error.
Feb 25 2020, 5:27 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), MW-1.34-notes, MediaWiki-Maintenance-system
Ostrzyciel created T246127: updateCollation.php throws an error.
Feb 25 2020, 5:04 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), MW-1.34-notes, MediaWiki-Maintenance-system

Feb 11 2020

Ostrzyciel closed T231481: Make WantedQueryPage::makeWlhLink protected instead of private as Resolved.
Feb 11 2020, 9:20 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), MediaWiki-General
Ostrzyciel added a comment to T240893: Support the revision_actor_temp table in Editcount.

@Aklapper: Ah, you're right, I forgot to close it :)

Feb 11 2020, 9:19 AM · MediaWiki-extensions-Editcount
Ostrzyciel closed T240893: Support the revision_actor_temp table in Editcount as Resolved.
Feb 11 2020, 9:19 AM · MediaWiki-extensions-Editcount

Jan 29 2020

Ostrzyciel closed T205219: AJAXPoll should handle when the DB is read-only as Resolved.
Jan 29 2020, 10:15 AM · AJAXPoll

Jan 28 2020

Ostrzyciel claimed T205219: AJAXPoll should handle when the DB is read-only.
Jan 28 2020, 10:37 PM · AJAXPoll
Ostrzyciel updated the task description for T243786: Allow different settings for galleries on special pages and categories.
Jan 28 2020, 11:13 AM · Patch-For-Review, MediaWiki-Gallery
Ostrzyciel updated the task description for T243786: Allow different settings for galleries on special pages and categories.
Jan 28 2020, 11:05 AM · Patch-For-Review, MediaWiki-Gallery

Jan 27 2020

Ostrzyciel created T243786: Allow different settings for galleries on special pages and categories.
Jan 27 2020, 5:45 PM · Patch-For-Review, MediaWiki-Gallery

Jan 19 2020

Ostrzyciel committed rEDISd7ff338a4cb3: Use a table alias for compatibility with other extensions (authored by Ostrzyciel).
Use a table alias for compatibility with other extensions
Jan 19 2020, 4:39 PM

Jan 6 2020

Ostrzyciel added a comment to T232305: Add hooks to the PPFrame::expand() method.

I suspect a more forward-compatible hook would be to hook link resolution, and pass in a reference to the frame there. The legacy parser is being replaced by Parsoid, so hooks based on the legacy parser aren't going to be maintainable long-term. However, Semantic MediaWiki wants to customize how [[....]] syntax is resolved, so we are likely to maintain some sort of hook based around that syntax.

Jan 6 2020, 9:15 AM · Patch-For-Review, MediaWiki-Parser

Dec 18 2019

Ostrzyciel added a comment to T232305: Add hooks to the PPFrame::expand() method.

I removed the $expansionDepth parameter entirely from both hooks. During testing it turned out to be returning mostly random numbers, depending on a lot of factors, that made it unusable in production.
The extension does not rely on this parameter anymore.

Dec 18 2019, 5:13 PM · Patch-For-Review, MediaWiki-Parser

Dec 16 2019

Ostrzyciel created T240893: Support the revision_actor_temp table in Editcount.
Dec 16 2019, 7:46 PM · MediaWiki-extensions-Editcount

Dec 4 2019

Ostrzyciel awarded T235551: InstantCommons should cache remote images a Like token.
Dec 4 2019, 7:48 PM · Core Platform Team (Icebox), Performance-Team (Radar), MediaWiki-File-management, Multimedia, Commons

Sep 13 2019

Ostrzyciel added a comment to T220765: Create a structured talkpage handler extension consistent with extant user talkpage expectations.

Note that storing all threads, or all messages of a thread, on a single slot, will make conflict resolution harder, depending on how the edit is handled (2 or more users adding or editing comments of the same thread)

Sep 13 2019, 11:31 PM · Epic, THICC, Uncyclomedia
Ostrzyciel updated the task description for T232305: Add hooks to the PPFrame::expand() method.
Sep 13 2019, 9:05 AM · Patch-For-Review, MediaWiki-Parser

Sep 9 2019

Ostrzyciel created T232305: Add hooks to the PPFrame::expand() method.
Sep 9 2019, 8:40 AM · Patch-For-Review, MediaWiki-Parser
Ostrzyciel updated the task description for T220258: Purge confirmation dialog should not be shown when user is member of "Purge" permission group.
Sep 9 2019, 6:43 AM · MediaWiki-General

Aug 28 2019

Ostrzyciel created T231481: Make WantedQueryPage::makeWlhLink protected instead of private.
Aug 28 2019, 4:50 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), MediaWiki-General

Jul 23 2019

Ostrzyciel placed T228771: Some configuration settings are not parsed up for grabs.

Nope, after investigating it I concluded I have no idea how to fix it. Looks like solving it elegantly would require a small redesign of how UW handles configuration from LocalSettings.php and campaigns. Halp.

Jul 23 2019, 5:22 PM · Multimedia, UploadWizard
Ostrzyciel added a comment to T228701: Make an option for the tutorial to be a customizable message (instead of an image).

While trying to do this, I encountered a serious bug with how UploadWizard parses its configuration settings, I will have to fix that first. See task T228771 for details.

Jul 23 2019, 4:21 PM · Patch-For-Review, Multimedia, UploadWizard
Ostrzyciel created T228771: Some configuration settings are not parsed.
Jul 23 2019, 4:19 PM · Multimedia, UploadWizard
Ostrzyciel added a comment to T228701: Make an option for the tutorial to be a customizable message (instead of an image).

On a second thought, my proposed solution isn't a very good one. The tutorial can be customized per-campaign and restricting it to a single MW message would mean losing that feature.

Jul 23 2019, 3:16 PM · Patch-For-Review, Multimedia, UploadWizard

Jul 22 2019

Ostrzyciel created T228701: Make an option for the tutorial to be a customizable message (instead of an image).
Jul 22 2019, 9:42 PM · Patch-For-Review, Multimedia, UploadWizard

Jul 21 2019

Ostrzyciel created T228584: Add special page aliases for Polish.
Jul 21 2019, 12:10 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), I18n, Multimedia, UploadWizard
Ostrzyciel created T228579: Make link to all categories configurable.
Jul 21 2019, 11:18 AM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Multimedia, UploadWizard
Ostrzyciel added a watcher for UploadWizard: Ostrzyciel.
Jul 21 2019, 11:11 AM

Jul 20 2019

Ostrzyciel awarded T14396: "what links here" should list the template, not the pages that use it a Love token.
Jul 20 2019, 10:09 PM · Discovery-Search, Community-Wishlist-Survey-2016, Schema-change, MediaWiki-Special-pages

Jul 3 2019

Ostrzyciel awarded T122924: Merge Extension:Theme into core a Love token.
Jul 3 2019, 8:20 PM · TechCom-RFC, Patch-For-Review, Technical-Debt, Theme, Front-end-Standards-Group, MediaWiki-Interface

May 20 2019

Ostrzyciel edited Description on THICC.
May 20 2019, 2:22 PM

May 19 2019

Ostrzyciel closed T223633: Create an extension homepage on mediawiki.org as Resolved.
May 19 2019, 12:38 PM · Wikimedia-Hackathon-2019, THICC
Ostrzyciel added a comment to T223633: Create an extension homepage on mediawiki.org.

Done: https://www.mediawiki.org/wiki/Extension:THICC

May 19 2019, 12:37 PM · Wikimedia-Hackathon-2019, THICC
Ostrzyciel committed rETHId872fae34be0: Add links to user talk pages and fix formatting a bit (authored by Ostrzyciel).
Add links to user talk pages and fix formatting a bit
May 19 2019, 12:02 PM
Ostrzyciel committed rETHI3e1f3d3f9776: Fixed an issue with an error when saving the page (authored by Ostrzyciel).
Fixed an issue with an error when saving the page
May 19 2019, 11:47 AM
Ostrzyciel committed rETHIcecce7693562: Fixed an issue with an error when saving the page (authored by Ostrzyciel).
Fixed an issue with an error when saving the page
May 19 2019, 11:47 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rETHI3e61cc3c1298: Merge "Actually remove the SQL stuff, we don't need that anymore" (authored by Ostrzyciel).
Merge "Actually remove the SQL stuff, we don't need that anymore"
May 19 2019, 11:34 AM
Ostrzyciel committed rETHId82617634993: Actually remove the SQL stuff, we don't need that anymore (authored by Ostrzyciel).
Actually remove the SQL stuff, we don't need that anymore
May 19 2019, 11:01 AM
Ostrzyciel committed rETHI662b04730be8: Removed SQL stuff, we don't need that anymore (authored by Ostrzyciel).
Removed SQL stuff, we don't need that anymore
May 19 2019, 10:39 AM
Ostrzyciel committed rETHIded185a5c911: bug: T223695 (authored by Ostrzyciel).
bug: T223695
May 19 2019, 10:17 AM
Ostrzyciel committed rETHIb16b81d3defc: WIP stuff for aggregate thing (authored by Ostrzyciel).
WIP stuff for aggregate thing
May 19 2019, 8:56 AM

May 18 2019

Ostrzyciel committed rETHI62dea1dbf5e2: Changed namespace name to THICC to make it thiccer (authored by Ostrzyciel).
Changed namespace name to THICC to make it thiccer
May 18 2019, 3:34 PM
Ostrzyciel committed rETHI0b411966401a: Add Thicc: and Thicc_talk: namespaces (authored by Ostrzyciel).
Add Thicc: and Thicc_talk: namespaces
May 18 2019, 2:46 PM
Ostrzyciel committed rETHI291b71ee9a3b: Added sql script for thicc table creation (authored by Ostrzyciel).
Added sql script for thicc table creation
May 18 2019, 12:02 PM

May 17 2019

Ostrzyciel added a comment to T220066: Create simplified, generic implementation of Oasis skin for current MediaWiki.

Here you go folks

May 17 2019, 2:49 PM · Uncyclomedia
Ostrzyciel committed rETHI63c6cf5725aa: Merge branch 'master' of ssh://gerrit.wikimedia.org… (authored by Ostrzyciel).
Merge branch 'master' of ssh://gerrit.wikimedia.org…
May 17 2019, 2:36 PM
Ostrzyciel committed rETHIbd7e78aafa1e: WIP stuff (authored by Ostrzyciel).
WIP stuff
May 17 2019, 2:32 PM
Ostrzyciel committed rETHIa793af4ece02: Boilerplate for extension (authored by Ostrzyciel).
Boilerplate for extension
May 17 2019, 2:05 PM
Ostrzyciel added a watcher for THICC: Ostrzyciel.
May 17 2019, 1:23 PM
Ostrzyciel added a member for THICC: Ostrzyciel.
May 17 2019, 1:22 PM

May 13 2019

Ostrzyciel added a comment to T223071: Custom license messages not being loaded in upload form.

I tested it on the latest MW 1.34.0-alpha 12th May 2019 with UploadWizard 1.5.0 12th May 2019 and on stable MW 1.32.0 with UploadWizard 1.5.0 14th October 2018. The problem exists on both of these version configurations.

May 13 2019, 12:00 PM · UploadWizard, Multimedia
Ostrzyciel created T223071: Custom license messages not being loaded in upload form.
May 13 2019, 8:39 AM · UploadWizard, Multimedia

Apr 6 2019

Ostrzyciel created T220258: Purge confirmation dialog should not be shown when user is member of "Purge" permission group.
Apr 6 2019, 9:31 AM · MediaWiki-General

Apr 5 2019

Ostrzyciel set IRC Nick to Ostrzyciel on Ostrzyciel.
Apr 5 2019, 2:27 PM