Page MenuHomePhabricator

Address some follow-up article theme issues
Closed, InvalidPublic

Assigned To
None
Authored By
Mhurd
Aug 16 2017, 6:35 PM
Referenced Files
F9357178: main-MainActivity-09062017140836.png
Sep 6 2017, 12:22 PM
F9357177: main-MainActivity-09062017140820.png
Sep 6 2017, 12:22 PM
F9357161: image.png
Sep 6 2017, 12:22 PM
F9357153: image.png
Sep 6 2017, 12:22 PM
F9357158: image.png
Sep 6 2017, 12:22 PM
F9174337: after.png
Aug 25 2017, 6:05 PM
F9115695: Screen Shot 2017-08-18 at 9.01.28 PM.png
Aug 19 2017, 4:07 AM
F9115693: Screen Shot 2017-08-18 at 9.03.53 PM.png
Aug 19 2017, 4:07 AM

Description

The following pages have some theme issues which should be fairly straightforward to address: (screenshots coming soon)

enwiki > Cambridge Blue (colour)

Event Timeline

https://github.com/wikimedia/wikimedia-page-library/pull/83

Fixed:

  • enwiki > Pantone
  • enwiki > Away colours

Appears correct already with latest page lib theme state:

  • enwiki > List of colors (compact)

Unfixed:
The problematic parts of these articles use inline style w/no class we can use. (nor are they contained by elements with distinct selectors we can use)
Users will have to switch back to normal theme to see intended colors on some parts of these articles.

  • enwiki > Shades of blue
  • enwiki > Cambridge Blue (colour)
  • enwiki > Esino Lario

Screenshots of the enwiki > Pantone article. (The PR associated with this ticket fixes theming for articles using color swatches.)

Before

Screen Shot 2017-08-16 at 4.35.02 PM.png (1×1 px, 504 KB)

After

Screen Shot 2017-08-16 at 4.32.58 PM.png (1×1 px, 504 KB)

Screenshots of enwiki > Away colours article.

Before

Screen Shot 2017-08-18 at 9.03.53 PM.png (995×1 px, 231 KB)

After

after.png (1×1 px, 253 KB)

@RHo

Good news and bad news:

The good is I was able to fix enwiki > Away colours (screenshot in comment above), bad news is enwiki > Esino Lario is one of the cases where the user will have to switch back to default - but luckily the table still shows the temperatures in dark/sepia, so it's still not bad :)

hi @Mhurd - the "Away colours" enwiki article is appearing not as expected in Dark mode on Android:

Light mode:
image.png (1×1 px, 153 KB)
Dark mode (image dimming on):
image.png (1×1 px, 162 KB)
Dark mode (image dimming off):
image.png (1×1 px, 149 KB)

Also @JMinor - did you want to keep this ticket open since there are some unfixed articles as mentioned by Monty? Color shades that appear in use inline styles in info boxes will not show in Dark mode, e.g., Cambridge Blue (colour):

Light
main-MainActivity-09062017140836.png (1×1 px, 175 KB)
Dark mode
main-MainActivity-09062017140820.png (1×1 px, 179 KB)

Unfixed:
The problematic parts of these articles use inline style w/no class we can use. (nor are they contained by elements with distinct selectors we can use)
Users will have to switch back to normal theme to see intended colors on some parts of these articles.

  • enwiki > Shades of blue
  • enwiki > Cambridge Blue (colour)
  • enwiki > Esino Lario
Mhurd removed Mhurd as the assignee of this task.Mar 18 2020, 7:34 PM

This is outdated. Closing to clear out old cruft.