Page MenuHomePhabricator

Get rid of the <legend> in RCFilters fieldset and minimize more vertical spaces
Closed, ResolvedPublic

Description

The <legend> still appears but has no reason to, and the <br>'s appear if there's even one show/hide option, but they take way too much space.

The commit below removes the legend and removes all <br />'s, instead setting the <span>s that are left inside the fieldset to display:block; to simulate a line-break but only where it is actually needed (without redundant <br> breaks that show a lot more whitespace below the text)

Details

Related Gerrit Patches:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 24 2017, 11:55 PM

Change 373716 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Minimize vertical spacing; get rid of legend and <br>s

https://gerrit.wikimedia.org/r/373716

Change 373716 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Minimize vertical spacing; get rid of legend and <br>s

https://gerrit.wikimedia.org/r/373716

Checked in betalabs - <legend> and <br> are removed from the collapsible element div id="BG_wiki" class="plainlinks". No regression in UI look.

Etonkovidova closed this task as Resolved.Sep 4 2017, 9:00 PM
Etonkovidova triaged this task as Low priority.