Page MenuHomePhabricator

Some users unable to complete oauth process
Closed, ResolvedPublic

Description

Several users (so far, @Lodewijk @Zanimum) have reported errors when trying to login to the platform. It appears to be an oauth token exchange error, although I haven't yet determined why it's impacting them, but not everyone. I'm going to throw away our current staging and test environments so that I can build a properly sized test environment based off of fresh config and content to try to get this issue reproduced and fixed.

ERROR TWLight.users.authorization[get]: Access token generation failed.
Traceback (most recent call last):
  File "/var/www/html/TWLight/TWLight/users/authorization.py", line 355, in get
    access_token = handshaker.complete(request_token, response_qs)
  File "/home/www/TWLight/local/lib/python2.7/site-packages/mwoauth/handshaker.py", line 90, in complete
    self.mw_uri, self.consumer_token, request_token, response_qs)
  File "/home/www/TWLight/local/lib/python2.7/site-packages/mwoauth/functions.py", line 184, in complete
    credentials.get(b('oauth_token'))[0],
TypeError: 'NoneType' object has no attribute '__getitem__'

Related Objects

Event Timeline

I've got a first pass at a fix deployed to the live site.

deployed a second pass to live site. I believe this should cover all remaining reported login issues, but we can hold this issue open to get reports back in

Samwalton9-WMF subscribed.

We've had two confirmations that this is resolved.