Page MenuHomePhabricator

Remove OO-UI from Special:NewFiles Media type field
Closed, ResolvedPublic

Description

The redesign from checkboxes in Special:NewFiles to an indescribable new input element, is nearly completely unusable for me! I disable JavaScript when visiting just to get the old interface back so I can't tell what's been unselected!

I'll try enumerating them:

  • Unable to determine state (what's missing?)
  • Suggests include states that cannot be set (can't list BITMAP twice, but it suggests it)
  • Appears to allow free typing input, but preforms unexpectedly behaviors upon focus lost (Invalid input is lost)
  • Unusual behavior when clicking text labels
  • Backspace remove letters not item
  • Remove hot spot (The 'X') is smaller
  • Interface misleads into thinking less items means fast load times
  • Cannot select text (e.g. select several labels to delete)

Edited to follow etiquette guidelines. Original was written after feeling insulted trying to select WP0 abused media types

Details

Related Gerrit Patches:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 29 2017, 11:26 PM
Dispenser updated the task description. (Show Details)Aug 29 2017, 11:51 PM
matthiasmullie added a subscriber: matthiasmullie.

That moron was me (https://gerrit.wikimedia.org/r/#/c/344158/) and I would appreciate a more constructive tone.

I can't remember exactly why I went with this instead of regular checkboxes - I guess I just thought this to be the most convenient at that time.
I find it works intuitively for the most part and don't share most of your issues with this UI element.

However, I do agree with your very first point and think it's a pretty strong one.
I definitely had not considered this, and it makes a very good case for switching it to a list of checkboxes.

Change 374814 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/core@master] Turn Special:NewFiles list of media types into list of checkboxes

https://gerrit.wikimedia.org/r/374814

@Dispenser: Insulting people is unacceptable. Please read and follow mw:Phabricator/Etiquette if you would like to use Wikimedia Phabricator. Thank you.

Dispenser updated the task description. (Show Details)Sep 4 2017, 12:11 PM

I liked the dropdown personally. Some of these are valid criticisms of the dropdown functionality, you might want to file OOUI bugs about them (this widget is a MenuTagMultiselectWidget: https://doc.wikimedia.org/oojs-ui/master/demos/?page=widgets&theme=wikimediaui&direction=ltr&platform=desktop#MenuTagMultiselectWidget-initially-selected-preset-options).

One thing you mention is intentional: "Backspace remove letters not item" – to remove whole items, use Ctrl+Backspace (also a common keyboard shortcut to delete whole words).

Change 374814 merged by jenkins-bot:
[mediawiki/core@master] Turn Special:NewFiles list of media types into list of checkboxes

https://gerrit.wikimedia.org/r/374814

matmarex closed this task as Resolved.Sep 4 2017, 4:25 PM
matmarex removed a project: Patch-For-Review.