Scribunto getfenv/setfenv tests failing
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Anomie
	Sep 5 2017, 7:43 PM

Description

In T173705#3581515, @Legoktm wrote:
I'm seeing failures in the Scribunto test suite using php-luasandbox 2.0.14 (my package for PHP7, not Wikimedia's HHVM one), but not under 2.0.13:
1) LuaSandbox: SandboxTests[1]: setfenv invalid level
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-ERROR: bad argument #1 to 'old_getfenv' (invalid level)
+ERROR: 'setfenv' cannot set the requested environment, it is protected

/home/km/projects/gerrit/mediawiki/extensions/Scribunto/tests/phpunit/engines/LuaCommon/LuaEngineTestBase.php:257
/home/km/projects/gerrit/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:415
/home/km/projects/gerrit/mediawiki/core/maintenance/doMaintenance.php:92

2) LuaSandbox: SandboxTests[2]: getfenv invalid level
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-ERROR: bad argument #1 to 'old_getfenv' (invalid level)
+{
+}
And on CI which is using the HHVM package: https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm-jessie/16036/console

At least locally downgrading to 2.0.13 makes all the tests pass again.

Details

Subject	Repo	Branch	Lines +/-
Fix tests	mediawiki/extensions/Scribunto	REL1_29	+2 -2
Fix tests	mediawiki/extensions/Scribunto	REL1_27	+2 -2
Fix tests	mediawiki/extensions/Scribunto	wmf/1.30.0-wmf.16	+2 -2
Fix tests	mediawiki/extensions/Scribunto	wmf/1.30.0-wmf.17	+2 -2
Fix tests	mediawiki/extensions/Scribunto	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned In: T175068: Run Scribunto test suite on luasandbox patches
Mentioned Here: T173705: HHVM: Unknown exception

Event Timeline

Anomie created this task.Sep 5 2017, 7:43 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 5 2017, 7:43 PM

Change 376082 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/extensions/Scribunto@master] Fix tests

https://gerrit.wikimedia.org/r/376082

gerritbot added a project: Patch-For-Review.Sep 5 2017, 7:45 PM

Anomie claimed this task.Sep 5 2017, 7:46 PM

Anomie added a project: Scribunto.

Change 376082 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Fix tests

https://gerrit.wikimedia.org/r/376082

Anomie closed this task as Resolved.Sep 5 2017, 8:06 PM

Legoktm mentioned this in T175068: Run Scribunto test suite on luasandbox patches.Sep 5 2017, 8:09 PM

Change 376157 had a related patch set uploaded (by Reedy; owner: Anomie):
[mediawiki/extensions/Scribunto@wmf/1.30.0-wmf.17] Fix tests

https://gerrit.wikimedia.org/r/376157

Change 376158 had a related patch set uploaded (by Reedy; owner: Anomie):
[mediawiki/extensions/Scribunto@wmf/1.30.0-wmf.16] Fix tests

https://gerrit.wikimedia.org/r/376158

Change 376157 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@wmf/1.30.0-wmf.17] Fix tests

https://gerrit.wikimedia.org/r/376157

Change 376158 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@wmf/1.30.0-wmf.16] Fix tests

https://gerrit.wikimedia.org/r/376158

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)).Sep 6 2017, 1:00 AM

Rical subscribed.Sep 6 2017, 1:37 PM

Change 409475 had a related patch set uploaded (by Legoktm; owner: Anomie):
[mediawiki/extensions/Scribunto@REL1_29] Fix tests

https://gerrit.wikimedia.org/r/409475

Change 409476 had a related patch set uploaded (by Legoktm; owner: Anomie):
[mediawiki/extensions/Scribunto@REL1_27] Fix tests

https://gerrit.wikimedia.org/r/409476

Change 409476 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@REL1_27] Fix tests