Page MenuHomePhabricator

En.WP Template:Taxobox -- where is the error? :D
Closed, ResolvedPublic

Description

We have no idea what is generating the "stripped tag" error in Template:Taxobox.

TLDR version: All of the templates and modules used in Template:Taxobox create well-formed <span> HTML and the pages using Taxobox do not have errant wikitext.

Is there is a bug in the software or did we miss something?

Event Timeline

Izno updated the task description. (Show Details)
Izno updated the task description. (Show Details)

Let us take a look at [[Streptomyces carpinensis]]. I effectively run it through expandtemplates API call and see this in the output '''<span class="binomial">'''''Streptomyces carpinensis'''''</span>''' which comes because of the template parameter | binomial = '''''Streptomyces carpinensis''''' This generates <b><span class="binomial"></b><i>Streptomyces carpinensis</i><b></span></b> which is really a case of bad nesting. Parsoid was unable to recognize it as misnested tags and is instead reporting it as pair of linter errors (a missing </span> end tag and a stripped </span> tag ).

But, going back to the infobox, it looks like the Taxobox is adding the bold tags around the span which conflicts with the 5 quotes that is being passed into the template itself. I am not sure what the right fix is here. Whether Taxobox should stop adding the bold around the parameter OR whether all pages that show up in the linter error category should fix the use of the taxobox to pass 2 quotes instead. That is something for you folks to decide. :-)

ssastry triaged this task as Medium priority.Sep 9 2017, 3:03 PM

You will see on https://en.wikipedia.org/wiki/Streptomyces_carpinensis that the listing under binomial name is not in bold at all. Only the italics is preserved. The two sets of bold tags are cancelling each other out.

Excellent, thanks. We'll talk it over onwiki about what to do.

You can close this, unless you want to track a case where Parsoid should/could be tracking a misnested issue (if that's even possible).

ssastry claimed this task.

Excellent, thanks. We'll talk it over onwiki about what to do.

Great.

You can close this, unless you want to track a case where Parsoid should/could be tracking a misnested issue (if that's even possible).

Parsoid does detect a subset of these scenarios as misnested tags -- and we have it on our todo list to improve that detection. So, this is a known thing on our radar. Will close this ticket.