Author: giecrilj

Description:
This is not a bug report but rather a code review remark. Preprocessor_Hash::preprocessToObj says:

00075 if ( strpos( $text, '<onlyinclude>' ) !== false && strpos( $text, '</onlyinclude>' ) !== false ) {
00076 $enableOnlyinclude = true;
00077 }

that means "</onlyinclude><onlyinclude>" is covered by the case.
Whas that intended?
I suppose it was not
and this is only some heuristic
to detect "<onlyinclude>…</onlyinclude>";
however, an obvious improvement seems to exist.

I would rather say this

if(
($oip = strpos($text, '<onlyinclude>')) !== false &&
strpos($text, '</onlyinclude>', $oip + strlen('<onlyinclude>'))
!= false)

Version: unspecified
Severity: trivial
URL: http://svn.wikimedia.org/doc/