[BUG] Share-a-fact removes parenthetical content from selected text
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	JoeWalsh
	Sep 14 2017, 11:03 AM

Description

How many times were you able to reproduce it?

Always

Steps to reproduce

Search for and open the "Lost operas by Claudio Monteverdi" article (or any article with content in parenthesis)
Select the text "The Italian composer Claudio Monteverdi (1567–1643), in addition to a large output of church music and madrigals, wrote" (or any text with parenthesis)
Wait for the popover menu to appear, select "Share-a-fact" if available, "Share" if not

Expected results

Text within parenthesis is in the resulting share a fact image

Actual results

Text within parenthesis is not in the resulting share a fact image

Regression?

No, and this looks like an intentional decision, so this is probably not really a bug but rather a change to expected behavior.

Related Objects

Mentioned In: rAPIOS804ad965f3d6: Merge pull request #1809 from wikimedia/bug/T175904
rAPIOSe437bf54ebdb: Merge branch 'develop' into bug/T175904
rAPIOS4cbef4fdb0a4: Merge branch 'bug/T175904' of https://github.com/wikimedia/wikipedia-ios into…
rAPIOS9436ed6ce0ff: Merge branch 'develop' into bug/T175904

Event Timeline

JoeWalsh created this task.Sep 14 2017, 11:03 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2017, 11:03 AM

• JMinor triaged this task as Low priority.Sep 18 2017, 6:10 PM

• JMinor moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.

• JMinor added a project: iOS-app-v5.7.0-Corgi-On-A-Surfboard.

• JMinor moved this task from Tasks from Product Backlog to Needs Acceptance Criteria on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.

Per our meeting discussion, this was intentional, but can be removed.

• NHarateh_WMF claimed this task.Sep 20 2017, 5:41 PM

• NHarateh_WMF moved this task from Ready for Development to Needs Code Review on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Sep 20 2017, 7:42 PM

• NHarateh_WMF mentioned this in rAPIOS9436ed6ce0ff: Merge branch 'develop' into bug/T175904.Sep 20 2017, 7:45 PM

• NHarateh_WMF mentioned this in rAPIOS4cbef4fdb0a4: Merge branch 'bug/T175904' of https://github.com/wikimedia/wikipedia-ios into….Sep 20 2017, 8:20 PM

JoeWalsh mentioned this in rAPIOSe437bf54ebdb: Merge branch 'develop' into bug/T175904.Sep 21 2017, 1:14 PM

JoeWalsh mentioned this in rAPIOS804ad965f3d6: Merge pull request #1809 from wikimedia/bug/T175904.

• NHarateh_WMF moved this task from Needs Code Review to Waiting for Build on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Sep 24 2017, 8:52 PM

JoeWalsh moved this task from Waiting for Build to Needs Design Review on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Sep 29 2017, 1:27 PM

Looks great, thanks!

Tested on iPhone 6s (iOS 10.3.3) and iPhone 7 (iOS 10.3.1) with Wikipedia app 5.7.0 (1235).
I got different results for each device according to the photos below, iPhone 6s was not able
to find the article, while iPhone 7 did display the text within parenthesis in the resulting
share a fact image.

Tested on iPad Pro with iOS 11.0 and iPhone 7+ with iOS 11.0.1 on App 5.7.0 (1239)

This is working for me. @Nicholas.tsg can you type "lost operas" into the iPhone 6 and see if the full article title appears in search suggestions?

Tested on iPhone 6s (iOS 10.3.3) but now using Wikipedia app 5.7.0 (1241). According to the photos below the "lost operas" article is now searchable on the device and share a fact button works as expected so this is fixed.

T175904 iPhone 6s lost operas.PNG (750×1 px, 126 KB)

T175904 iPhone 6s share a fact.PNG (1×750 px, 407 KB)

Looks good on 5.7.0 (1244)

• JMinor closed this task as Resolved.Oct 30 2017, 10:01 PM

	F10060332: T175904 iPhone 6s lost operas.PNG
	Oct 7 2017, 6:37 PM

	F10060333: T175904 iPhone 6s share a fact.PNG
	Oct 7 2017, 6:37 PM

[BUG] Share-a-fact removes parenthetical content from selected textClosed, ResolvedPublicActions