Page MenuHomePhabricator
Create Task
Maniphest T176355

New payments-wiki errors: We don't have an order status after doing a GET_ORDERSTATUS
Closed, ResolvedPublic
Actions

Description

Saw some in the globalcollect error log from September 20th.

Yikes, is this related to the minor GC refactor to accomodate Ingenico?

Details

SubjectRepoBranchLines +/-
Fix missing order statusmediawiki/extensions/DonationInterfacemaster+12 -1
Customize query in gerrit

Event Timeline

Ejegg created this task.Sep 20 2017, 8:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 20 2017, 8:36 PM
• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Sep 25 2017, 7:44 PM
• DStrine moved this task from Sprint +1 to Current Sprint and Completed in Q1 2017-18 on the Fundraising-Backlog board.Sep 26 2017, 8:23 PM
• DStrine added a project: Fundraising Sprint Synchronized Screaming.Sep 26 2017, 8:45 PM
Ejegg claimed this task.Sep 29 2017, 5:29 PM
Ejegg triaged this task as High priority.
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Synchronized Screaming board.
Ejegg added a comment.Oct 3 2017, 1:01 AM

Well, they're all related to 20001000 NULL VALUE NOT ALLOWED FOR EXPIRYDATE errors. Those didn't seem to give us the same errors before 9/21, so looking in the code deployed on that date.

Ejegg added a comment.Oct 3 2017, 1:12 AM

Aha, we were previously looking at the raw STATUSID from globalcollect, and changed to looking at the unstaged 'gateway_status'. Guessing we're not unstaging data under certain circumstances.

gerritbot subscribed.Oct 3 2017, 1:39 AM

Change 381918 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Fix missing order status

https://gerrit.wikimedia.org/r/381918

gerritbot added a project: Patch-For-Review.Oct 3 2017, 1:39 AM
Ejegg moved this task from Doing to Review on the Fundraising Sprint Synchronized Screaming board.Oct 3 2017, 1:39 AM
XenoRyet moved this task from Review to Pending Deployment on the Fundraising Sprint Synchronized Screaming board.Oct 3 2017, 4:27 PM
gerritbot added a comment.Oct 3 2017, 4:29 PM

Change 381918 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Fix missing order status

https://gerrit.wikimedia.org/r/381918

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)).Oct 3 2017, 5:00 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Synchronized Screaming board.Oct 3 2017, 5:42 PM
Ejegg closed this task as Resolved.Oct 10 2017, 8:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL