Maniphest T176965

Upstream AnyComponent definition to preact
Closed, ResolvedPublic
Actions

Assigned To

• Niedzielski

Authored By

	• Jhernandez
	Sep 28 2017, 1:54 PM

Tags

Referenced Files

None

Subscribers

• Niedzielski

Tokens

"Burninate" token, awarded by Jhernandez.

Description

Upstream the useful definition to the preact repo.

preact-utils.ts

// todo: consider upstreaming type definition for AnyComponent
export type AnyComponent<PropsType, StateType> =
  | FunctionalComponent<PropsType>
  | ComponentConstructor<PropsType, StateType>;

Also upstream the change to use the new preact definition on preact-router, which also needed to re-define it itself as seen on:
https://github.com/developit/preact-router/blob/master/src/index.d.ts#L51-L53

Details

	Subject	Repo	Branch	Lines +/-
	Chore: upgrade dependencies	marvin	master	+141 -140

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Declined		None	T176962 Upstreaming efforts
		Resolved		• Niedzielski	T176965 Upstream AnyComponent definition to preact

Event Timeline

• Jhernandez created this task.Sep 28 2017, 1:54 PM

https://github.com/developit/preact/pull/906

Change 387583 had a related patch set uploaded (by Niedzielski; owner: Sniedzielski):
[marvin@master] Chore: upgrade dependencies

https://gerrit.wikimedia.org/r/387583

gerritbot added a project: Patch-For-Review.Oct 31 2017, 2:38 PM

• Niedzielski mentioned this in rMARVd320308ede44: Chore: upgrade dependencies.Oct 31 2017, 2:38 PM

• Niedzielski changed the task status from Stalled to Open.Oct 31 2017, 2:38 PM

• Niedzielski moved this task from Needs Triage to Backlog (Priority Descending) on the Marvin board.Oct 31 2017, 3:08 PM

• Niedzielski mentioned this in rMARV2af379e99382: Chore: upgrade dependencies.Oct 31 2017, 6:22 PM

• Niedzielski mentioned this in rMARV39fbc23bc35d: Chore: upgrade dependencies.Nov 1 2017, 10:29 PM

• Niedzielski mentioned this in rMARV8a51bac6bca3: Chore: upgrade dependencies.Nov 2 2017, 12:44 PM

• Niedzielski mentioned this in rMARVe9a658822566: Chore: upgrade dependencies.Nov 2 2017, 2:10 PM

• Niedzielski mentioned this in rMARV01d8b7f83eaf: Chore: upgrade dependencies.Nov 6 2017, 2:07 PM

• Niedzielski mentioned this in rMARV3a9ad2f41022: Chore: upgrade dependencies.Nov 7 2017, 7:42 PM

• Niedzielski mentioned this in rMARVd119e0df4714: Chore: upgrade dependencies.Nov 8 2017, 7:14 PM

Change 387583 merged by jenkins-bot:
[marvin@master] Chore: upgrade dependencies

https://gerrit.wikimedia.org/r/387583

• Niedzielski closed this task as Resolved.Nov 8 2017, 7:20 PM

• Jhernandez awarded a token.Nov 13 2017, 5:06 PM