Page MenuHomePhabricator

Cached thresholds should be invalidated for new model versions.
Closed, ResolvedPublic


My quick + dirty suggestion is that we add the model version to the threshold cache key. That lets us roll back or forward with ease.

The drawback is that we would be making a database call as part of every getThresholds call, AIUI.

Event Timeline

@awight: good first task tasks are self-contained, non-controversial issues with a clear approach and should be well-described with pointers to help the new contributor. Given the current short task description I'm removing the good first task tag. Please re-add the tag once the task description has been polished and provides sufficient information for a new contributor. Thanks!

This is done around one month ago, by adding model version to cache key. I did it.