Page MenuHomePhabricator
Create Task
Maniphest T177514

"Replace" (in Search and Replace) doesn't scroll the page
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

In this thread a user was expecting the page to scroll consistently (as in, center the page to show which word is highlighted) while they kept Replacing words. The feature works, as in it does replace the words even when they are further below in the article and you don't see them, but at this point it's the same than using Replace All, isn't it.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (9b32da86d)mediawiki/extensions/VisualEditormaster+1 -1
Scroll to the next highlight after find and replace has replaced textVisualEditor/VisualEditormaster+3 -0
Customize query in gerrit

Related Objects

Event Timeline

• Elitre created this task.Oct 5 2017, 4:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2017, 4:28 PM
• Deskana triaged this task as Medium priority.Oct 24 2017, 11:05 AM
• Deskana set the point value for this task to 1.
• Deskana moved this task from To Triage to TR1: Releases on the VisualEditor board.
• Deskana subscribed.

That's odd.

• Deskana claimed this task.Oct 24 2017, 1:02 PM
gerritbot subscribed.Oct 24 2017, 1:04 PM

Change 386171 had a related patch set uploaded (by Deskana; owner: Deskana):
[VisualEditor/VisualEditor@master] Scroll to the next highlight after find and replace has replaced text

https://gerrit.wikimedia.org/r/386171

gerritbot added a project: Patch-For-Review.Oct 24 2017, 1:04 PM
gerritbot added a comment.Oct 24 2017, 10:45 PM

Change 386171 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Scroll to the next highlight after find and replace has replaced text

https://gerrit.wikimedia.org/r/386171

• Deskana closed this task as Resolved.Oct 25 2017, 5:04 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 25 2017, 5:04 PM
gerritbot added a comment.Oct 25 2017, 6:29 PM

Change 386047 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (9b32da86d)

https://gerrit.wikimedia.org/r/386047

gerritbot added a comment.Oct 25 2017, 8:24 PM

Change 386047 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (9b32da86d)

https://gerrit.wikimedia.org/r/386047

Jdforrester-WMF edited projects, added VisualEditor-EditingTools, MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)); removed Patch-For-Review.Oct 30 2017, 3:02 PM
Ryasmeen added a project: Verified.Oct 30 2017, 10:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits