Page MenuHomePhabricator
Create Task
Maniphest T177803

Donation queue consumer crash on unknown country
Closed, ResolvedPublic
Actions

Description

See donations_queue_consume-20171009-182702.log - We should either import the thing anyway, or drop it in the damaged db and continue with the next donation

Details

SubjectRepoBranchLines +/-
Drop addresses without countrywikimedia/fundraising/crmmaster+17 -16
PayPal: map Netherlands Antilles to Netherlandsmediawiki/extensions/DonationInterfacemaster+8 -3
Customize query in gerrit

Related Objects

Event Timeline

Ejegg created this task.Oct 9 2017, 9:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2017, 9:47 PM
Ejegg added a comment.Oct 9 2017, 11:52 PM

This is a DB Error: constraint violation

• DStrine triaged this task as High priority.Oct 10 2017, 8:28 PM
• DStrine moved this task from Triage to Current Sprint and Completed in Q1 2017-18 on the Fundraising-Backlog board.
• DStrine added a project: Fundraising Sprint turtles that are robotic that destroy the whole world with their foot.Oct 10 2017, 8:30 PM
XenoRyet claimed this task.Oct 11 2017, 5:31 PM
XenoRyet moved this task from Backlog to Doing on the Fundraising Sprint turtles that are robotic that destroy the whole world with their foot board.
gerritbot subscribed.Oct 12 2017, 6:57 PM

Change 383897 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] PayPal: map Netherlands Antilles to Netherlands

https://gerrit.wikimedia.org/r/383897

gerritbot added a project: Patch-For-Review.Oct 12 2017, 6:57 PM
gerritbot added a comment.Oct 12 2017, 7:05 PM

Change 383900 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Drop addresses without country

https://gerrit.wikimedia.org/r/383900

XenoRyet reassigned this task from XenoRyet to Ejegg.Oct 12 2017, 7:35 PM
XenoRyet subscribed.
gerritbot added a comment.Oct 12 2017, 7:35 PM

Change 383897 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] PayPal: map Netherlands Antilles to Netherlands

https://gerrit.wikimedia.org/r/383897

XenoRyet moved this task from Doing to Pending Deployment on the Fundraising Sprint turtles that are robotic that destroy the whole world with their foot board.Oct 12 2017, 7:35 PM
gerritbot added a comment.Oct 12 2017, 7:42 PM

Change 383900 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Drop addresses without country

https://gerrit.wikimedia.org/r/383900

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)).Oct 12 2017, 8:00 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint turtles that are robotic that destroy the whole world with their foot board.Oct 12 2017, 8:13 PM

OK, this particular badness won't crash our queue consumer any more, but we need to deal with the general problem: T178104

Ejegg closed this task as Resolved.Oct 12 2017, 8:16 PM

The previously-crashy ones have been re-queued via the audit files, and the re-import did not crash. We did lose the mailing address data.

Ejegg mentioned this in T177806: Coinbase import error.Oct 12 2017, 8:41 PM
• DStrine moved this task from Current Sprint and Completed in Q1 2017-18 to Completed in Q2 2017-18 on the Fundraising-Backlog board.Oct 20 2017, 5:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits