Page MenuHomePhabricator
Create Task
Maniphest T178461

Adapt components for new editing metrics
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Before activating the new editing metrics added in T175268, there are a few changes needed to be pushed:

  • Unify date format so that only JS date objects are dealt with internally (no string-based timestamps).
  • Fix breakdowns not rendering properly when there is more than one possibility available.
  • Render metric numbers with their correct suffix/format (with floating point, units, bytes...).

Details

SubjectRepoBranchLines +/-
Handle negative values in graphsanalytics/wikistats2master+80 -18
Query breakdowns only when they are visualisedanalytics/wikistats2master+147 -124
Only query breakdowns when they are to be visualisedanalytics/wikistats2master+155 -117
Customize query in gerrit

Related Objects

Event Timeline

• fdans created this task.Oct 18 2017, 9:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2017, 9:59 AM
• fdans set the point value for this task to 8.Oct 18 2017, 10:00 AM
• fdans added a project: Data-Engineering-Wikistats.Oct 18 2017, 9:05 PM
gerritbot subscribed.Oct 23 2017, 9:58 AM

Change 385954 had a related patch set uploaded (by Fdans; owner: Fdans):
[analytics/wikistats2@master] Only queries breakdowns when they are to be visualised

https://gerrit.wikimedia.org/r/385954

gerritbot added a project: Patch-For-Review.Oct 23 2017, 9:58 AM
Milimetric moved this task from In Progress to In Code Review on the Analytics-Kanban board.Oct 23 2017, 2:17 PM
gerritbot added a comment.Oct 30 2017, 5:35 PM

Change 385954 abandoned by Fdans:
Only query breakdowns when they are to be visualised

Reason:
Abandoning as I've done something strange with the change ids

https://gerrit.wikimedia.org/r/385954

gerritbot added a comment.Oct 30 2017, 6:24 PM

Change 387320 had a related patch set uploaded (by Milimetric; owner: Milimetric):
[analytics/wikistats2@master] Query breakdowns only when they are visualised

https://gerrit.wikimedia.org/r/387320

gerritbot added a comment.Oct 30 2017, 6:24 PM

Change 387320 merged by Milimetric:
[analytics/wikistats2@master] Query breakdowns only when they are visualised

https://gerrit.wikimedia.org/r/387320

gerritbot added a comment.Oct 31 2017, 12:57 PM

Change 387561 had a related patch set uploaded (by Fdans; owner: Fdans):
[analytics/wikistats2@master] Handle negative values in graphs

https://gerrit.wikimedia.org/r/387561

• fdans moved this task from In Code Review to Ready to Deploy on the Analytics-Kanban board.Oct 31 2017, 3:10 PM
gerritbot added a comment.Oct 31 2017, 5:32 PM

Change 387561 merged by Milimetric:
[analytics/wikistats2@master] Handle negative values in graphs

https://gerrit.wikimedia.org/r/387561

• fdans moved this task from Ready to Deploy to Done on the Analytics-Kanban board.Nov 2 2017, 2:59 PM
• Nuria closed this task as Resolved.Nov 6 2017, 8:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL