Page MenuHomePhabricator
Create Task
Maniphest T179654

Title of new section in NWE not automatically spellchecked
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

When you add a new section using NWE, spellchecking is not enabled by default for the title input (at least in Firefox), because <input> fields aren't spellchecked by default.

newsection.png (259×590 px, 18 KB)

Setting spellcheck="true" (https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/spellcheck) enables spellchecking for the title as well, and I don't see any reason not to do so.

Details

SubjectRepoBranchLines +/-
DesktopArticleTarget: enable spellcheck on sectionTitlemediawiki/extensions/VisualEditormaster+2 -1
TextInputWidget: support spellcheck attributeoojs/uimaster+10 -0
Customize query in gerrit

Related Objects

Event Timeline

Schnark created this task.Nov 3 2017, 10:27 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptNov 3 2017, 10:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Nov 14 2017, 5:31 PM

Change 391256 had a related patch set uploaded (by DLynch; owner: DLynch):
[oojs/ui@master] TextInputWidget: support spellcheck attribute

https://gerrit.wikimedia.org/r/391256

gerritbot added a project: Patch-For-Review.Nov 14 2017, 5:31 PM
gerritbot added a comment.Nov 14 2017, 9:51 PM

Change 391256 merged by jenkins-bot:
[oojs/ui@master] TextInputWidget: support spellcheck attribute

https://gerrit.wikimedia.org/r/391256

gerritbot added a comment.Nov 15 2017, 5:17 PM

Change 391587 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget: enable spellcheck on sectionTitle

https://gerrit.wikimedia.org/r/391587

• Deskana assigned this task to DLynch.Nov 17 2017, 11:32 AM
• Deskana set the point value for this task to 1.
• Deskana moved this task from To Triage to TR1: Releases on the VisualEditor board.
gerritbot added a comment.Nov 29 2017, 12:38 AM

Change 391587 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget: enable spellcheck on sectionTitle

https://gerrit.wikimedia.org/r/391587

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)).Nov 29 2017, 1:01 AM
Jdforrester-WMF closed this task as Resolved.Nov 29 2017, 1:14 AM
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptNov 29 2017, 1:14 AM
Schnark mentioned this in T182393: Alt text for images should be spellchecked in Firefox.Dec 8 2017, 9:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL