Page MenuHomePhabricator
Create Task
Maniphest T180298

Catchable fatal error: Argument 1 passed to CirrusSearch\DataSender::reportUpdateMetrics() must be an instance of Elastica\Bulk\ResponseSet, null given
Closed, ResolvedPublic
Actions

Description

I am getting lot of this error from the JobQueue:

2017-11-12 10:48:41 cirrusSearchElasticaWrite Nimitys:umpirauhanen method=sendData arguments=["general",[{}]] cluster=default createdAt=1510296812 errorCount=2 retryCount=0 requestId=WgMn-TXYt-QiQrUqZmUcyAAAAAE (id=94851619,timestamp=20171112104815) STARTING
2017-11-12 10:48:42 cirrusSearchElasticaWrite Nimitys:umpirauhanen method=sendData arguments=["general",[{}]] cluster=default createdAt=1510296812 errorCount=2 retryCount=0 requestId=WgMn-TXYt-QiQrUqZmUcyAAAAAE (id=94851619,timestamp=20171112104815) t=687 good
2017-11-12 10:48:42 cirrusSearchElasticaWrite Nimitys:tuuliviirin_varsi method=sendData arguments=["general",[{}]] cluster=default createdAt=1510323872 errorCount=1 retryCount=0 requestId=WgMn-TXYt-QiQrUqZmUcyAAAAAE (id=94615369,timestamp=20171110142432) STARTING
Catchable fatal error: Argument 1 passed to CirrusSearch\DataSender::reportUpdateMetrics() must be an instance of Elastica\Bulk\ResponseSet, null given in /srv/mediawiki/tags/2017-11-12_10:40:00/extensions/CirrusSearch/includes/DataSender.php on line 264
Warning: Destructor threw an object exception: exception 'Wikimedia\Rdbms\DBTransactionError' with message 'Wikimedia\Rdbms\LBFactory::shutdown: transaction round 'CirrusSearch\Job\ElasticaWrite::run' still running.' in /srv/mediawiki/tags/2017-11-12_10:40:00/includes/libs/rdbms/lbfactory/LBFactory.php:215
Stack trace:
#0 /srv/mediawiki/tags/2017-11-12_10:40:00/includes/libs/rdbms/lbfactory/LBFactory.php(143): Wikimedia\Rdbms\LBFactory->commitMasterChanges()
#1 /srv/mediawiki/tags/2017-11-12_10:40:00/includes/libs/rdbms/lbfactory/LBFactory.php(129): Wikimedia\Rdbms\LBFactory->shutdown()
#2 /srv/mediawiki/tags/2017-11-12_10:40:00/includes/libs/rdbms/lbfactory/LBFactory.php(581): Wikimedia\Rdbms\LBFactory->destroy()
#3 (): Wikimedia\Rdbms\LBFactory->__destruct()
#4 {main}

Versions:

  • MediaWiki 1.31.0-alpha
  • HHVM 3.15.0 (srv)
  • MariaDB 5.5.52-MariaDB
  • ICU 50.1.2
  • Elasticsearch 5.5.1

MediaWiki, Elastica and CirrusSearch from git master.

Is this a configuration error, version mismatch or a bug?

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/CirrusSearchREL1_29+4 -1Don't try to report update metrics if the response is not valid
mediawiki/extensions/CirrusSearchREL1_30+4 -1Don't try to report update metrics if the response is not valid
mediawiki/extensions/CirrusSearchmaster+4 -1Don't try to report update metrics if the response is not valid
Customize query in gerrit

Event Timeline

Nikerabbit created this task.Nov 12 2017, 10:59 AM
Restricted Application added projects: Discovery-ARCHIVED, Discovery-Search. · View Herald TranscriptNov 12 2017, 10:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• dcausse added a subscriber: • dcausse.Nov 13 2017, 1:15 PM

It's a bug but the only explanation I have to explain why this error is frequent is that your index may have run out of date. Reading the code I understand that this error could only happen when trying to update some metadata in elasticsearch concerning a document that is not indexed.

gerritbot added a subscriber: gerritbot.Nov 13 2017, 1:15 PM

Change 390990 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Don't try to report update metrics if the response is not valid

https://gerrit.wikimedia.org/r/390990

gerritbot added a project: Patch-For-Review.Nov 13 2017, 1:15 PM
• dcausse claimed this task.Nov 13 2017, 1:17 PM
• dcausse triaged this task as Medium priority.
• dcausse moved this task from needs triage to This Quarter on the Discovery-Search board.
• dcausse moved this task from This Quarter to Current work on the Discovery-Search board.
• dcausse edited projects, added Discovery-Search (Current work); removed Discovery-Search.
• dcausse moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.
gerritbot added a comment.Nov 13 2017, 4:42 PM

Change 390990 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Don't try to report update metrics if the response is not valid

https://gerrit.wikimedia.org/r/390990

EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Nov 13 2017, 4:48 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)).Nov 13 2017, 5:00 PM
gerritbot added a comment.Nov 17 2017, 7:58 AM

Change 392001 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@REL1_30] Don't try to report update metrics if the response is not valid

https://gerrit.wikimedia.org/r/392001

gerritbot added a comment.Nov 17 2017, 7:58 AM

Change 392002 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@REL1_29] Don't try to report update metrics if the response is not valid

https://gerrit.wikimedia.org/r/392002

gerritbot added a comment.Nov 21 2017, 1:34 AM

Change 392001 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@REL1_30] Don't try to report update metrics if the response is not valid

https://gerrit.wikimedia.org/r/392001

debt closed this task as Resolved.Dec 1 2017, 4:49 PM
gerritbot added a comment.Dec 6 2017, 10:59 AM

Change 392002 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@REL1_29] Don't try to report update metrics if the response is not valid

https://gerrit.wikimedia.org/r/392002

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL