| Quiddity | |
| Nov 16 2017, 2:32 AM |
| F11194277: orlikethat.png | |
| Dec 5 2017, 3:07 PM |
| F11194261: after.png | |
| Dec 5 2017, 3:07 PM |
| F11194259: before.png | |
| Dec 5 2017, 3:07 PM |
| F10816630: Selection_006.jpg | |
| Nov 16 2017, 2:32 AM |
I was looking at the error page during the scheduled Phabricator update, and noticed the error page has a consistent linewrap problem in Firefox, in the second paragraph. In Chromium the problem occurs at smaller window sizes (under ~680px), but not at larger sizes.
Screenshot: Firefox vs Chrome
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| mediawiki: Fix linewrap issue on wikimedia error page | operations/puppet | production | +2 -1 |
Should be as simple as increasing the CSS value for the bottom in the line img { float: left; margin: 0 2em 2em 0; } in the file operations/puppet/modules/mediawiki/templates/errorpage.html.erb.
Happy to mentor this for Google-Code-in-2017.
Change 395552 had a related patch set uploaded (by Phantom42; owner: Phantom42):
[operations/puppet@production] Fix linewrap issue on wikimedia error page
Well, increasing CSS value for bottom is a working solution, but I think there is more optimal solution available. We can just put error text in to a p tag and set overflow: hidden; for it. This will always prevent text from wrapping.
By the way, I think it would be good to improve the look of this page on mobile screens. For example, we could display logo at full screen width and place text under it. I think this will look better on smaller screens. What do you think about this? If needed, I may show you some screenshots, so you better understand what I mean.
I just pushed fix to Gerrit. I tested it a bit in both Chrome and Firefox.
Before:
After:
Or even this:
If anything needs fixing in that patch - please tell and I will do it!
@Phantom42: Hah - thanks, your solution is better indeed! I don't have merge rights on that repo so this Phab task will remain open but I'll close the GCI task. :)
@Aklapper: And what about changing layout a bit on devices with small screens (more details in my previous message). Or there is no need for that and fixing that linewrap issue was enough?
I personally like the idea but would love to get more input on that one... Worth a separate task? :)
+1 to good idea but new task. It's good to keep things clearly separated (in both discussion and patchset), where possible/practical.
Change 395552 merged by Dzahn:
[operations/puppet@production] mediawiki: Fix linewrap issue on wikimedia error page
Thank you for reviewing and merging! Now we can continue our work on this page by improving layout on mobile devices in T182247.