Page MenuHomePhabricator
Create Task
Maniphest T180977

[BUG] Disabling Offline Library doesn't disable it all
Closed, InvalidPublic1 Estimated Story Points
Actions

Description

When I disable offline library I expect to see no trace of the offline library while using the app until I enable it. With the alpha version of the app dated 17Nov2017, I don't think it's disabled very strictly as I see many traces of the offline library even after disabling it.

Pre-requisite

  1. Ensure you have at least one ZIM file
  2. You have enabled the Offilne Library and then disabled it at least once in the Settings.
  3. The Offline library feature is currently disabled.

1. "Manage Offline Library" card is shown in Explore feed when device is offline

Steps to reproduce
  1. Go offline
  2. Go to the explore feed
Expected results

The card shouldn't be shown when device is offline and offline library is disabled.

Actual results

The card is shown even though offline library feature has been disabled.

Screenshot

Screenshot_2017-11-16-15-20-08.png (960×540 px, 90 KB)

2. Searching while offline shows results from Offline Library

Steps to reproduce
  1. Download the "Medical Wiki/TA" article pack
  2. Go offline
  3. Tap in the 'Search' icon
  4. Search for தசை
Expected results

The Search results from Offline Library message is not shown and search results from the offline article pack are not shown.

Actual results

The Search results from Offline Library message is shown and search results from the offline article pack are shown.

Screenshot

Screenshot_2017-11-18-07-51-35.png (960×540 px, 72 KB)

3. "Prefer offline" content loads article from Offline Library (if present)

Steps to reproduce
  1. Download the "Medical Wiki/TA" article pack
  2. Ensure "Prefer offline content" is enabled
  3. Go online
  4. Change search language to Tamil (TA)
  5. Tap in the 'Search' icon
  6. Search for தசை
  7. Tap on the article titled தசை
Expected results

The online version of the article is loaded rather than the article form the Medical Wiki/TA article pack.

Actual results

The version of the article Medical Wiki/TA article pack is loaded rather than the online version of the article.

Environments observed

App version: alpha (17Nov2017)
Android OS version: 5.1.1
Device model: Galaxy J2
Device language: English

Update

  • Still occurring on Wikipedia v2.7.221-alpha-2017-12-12
  • Still occurring on Wikipedia v2.7.224-alpha-2018-01-19

Related Objects

Event Timeline

Kaartic created this task.Nov 20 2017, 5:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 20 2017, 5:33 PM
Kaartic renamed this task from Disabling Offline Library doesn't completely diable it to Disabling Offline Library doesn't completely disable it.Nov 25 2017, 6:40 PM
Dbrant moved this task from Needs Triage to Bug Backlog on the Wikipedia-Android-App-Backlog board.Nov 27 2017, 1:30 PM
RHo added a project: Android-app-feature-Compilations.Dec 12 2017, 2:57 PM
RHo subscribed.
RHo renamed this task from Disabling Offline Library doesn't completely disable it to [BUG] Disabling Offline Library doesn't disable it all.Dec 12 2017, 3:10 PM
RHo updated the task description. (Show Details)
RHo added a comment.Jan 18 2018, 3:40 PM

Just checked and this is only occurring after a user has enabled Offline library and then disabled it again, ie the root cause seems to be that the permission is not being revoked.

RHo mentioned this in T179070: Test for error conditions in the sideloading-only version of the Offline Library.Jan 18 2018, 3:41 PM
Kaartic added a comment.EditedJan 18 2018, 4:14 PM
In T180977#3909861, @RHo wrote:

Just checked and this is only occurring after a user has enabled Offline library and then disabled it again,

Nice catch. It's quite possible that you're right though I haven't checked this. I guess the "Steps to reproduce" need some updation now, though I can't update them currently as I can't verify it. I'll update them when I do verify this but it would be nice if someone did it in the mean time :-)

ie the root cause seems to be that the permission is not being revoked.

This makes me wonder. Assuming you're referring to the "Storage permission" the app obtains when I enable the "Offliine Library" in Android 6 and above, I hope you're not saying that some Offline library related features work when they have access to storage regardless of whether the Offline library is enable or not? I find that to be a bad thing because,

  • It makes the option "Enable offline library" meaningless
  • You don't even need to ask for permission for Android versions less than 6 (I suspect, I'm being sloppy here)

Of course if you're referring to some other permission the above statements don't make any sense. BTW, what's the "some other permission", anyway?

Kaartic updated the task description. (Show Details)Jan 19 2018, 11:10 AM
Kaartic added a comment.EditedJan 19 2018, 1:52 PM

I guess the "Steps to reproduce" need some updation now, though I can't update them currently as I can't verify it. I'll update them when I do verify this but it would be nice if someone did it in the mean time :-)

I've verified this on a different device. I've also updated the Steps to reproduce. Hope it reflects the scenario correctly.

Dbrant closed this task as Invalid.Jun 5 2018, 3:36 PM
Dbrant subscribed.

No longer accepting bug tickets for Offline Library since the feature is currently shelved (T195518) and will likely be very different when brought back.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL