Page MenuHomePhabricator
Create Task
Maniphest T181104

Tweak Featured article widget "Save for later" button color
Closed, ResolvedPublic
Actions

Description

@cmadeo provided a slightly different blue to use which had better contrast on the gray widget background

Before

IMG_2760.PNG (2×1 px, 1 MB)

After

IMG_2759.PNG (2×1 px, 1 MB)

Related Objects

Event Timeline

Mhurd created this task.Nov 21 2017, 10:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 21 2017, 10:38 PM
Mhurd added a comment.Nov 21 2017, 10:40 PM

https://github.com/wikimedia/wikipedia-ios/pull/1943

Mhurd updated the task description. (Show Details)Nov 21 2017, 10:44 PM
JoeWalsh mentioned this in rAPIOSe769e469879f: Merge pull request #1943 from wikimedia/update/widget-save-button-color/T181104.Nov 27 2017, 12:26 PM
JoeWalsh mentioned this in rAPIOS4d44e3860f20: Merge branch 'develop' into update/widget-save-button-color/T181104.
• JMinor triaged this task as Lowest priority.Nov 27 2017, 8:08 PM
• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.
JoeWalsh moved this task from Needs Code Review to Needs Design Review on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Nov 27 2017, 8:08 PM
cmadeo moved this task from Needs Design Review to Needs QA on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Nov 30 2017, 9:44 PM

Looks good! Thanks Monte!

Nicholas.tsg subscribed.Dec 5 2017, 8:50 PM

Testing on iPhone 6 Plus (iOS 11.1.2) and Wikipedia app 5.7.2 (1267). Featured article widget "Save for later" button color is shown in screencaps below, I have posted two examples as this is a tough call comparing them to the "After" photo above, the reason being my devices do not cap the exact color specs on the screen.

T1811041.PNG (2×1 px, 3 MB)
T1811042.jpg (4×3 px, 2 MB)

ABorbaWMF moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Dec 13 2017, 9:12 PM
ABorbaWMF subscribed.

Wikipedia app 5.7.3 (1281) - Looks good to me, especially if it looks good to @cmadeo

• JMinor closed this task as Resolved.Jan 8 2018, 10:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits