Page MenuHomePhabricator
Create Task
Maniphest T181159

Migrate ORES extension threshold config from old to new syntax
Closed, ResolvedPublic
Actions

Description

This should be done carefully, starting with beta cluster config. Edit $wgOresFiltersThresholds in wmf-config/InitialiseSettings.php and change from the old syntax, e.g. recall_at_precision(min_precision=0.15) to the new syntax:
maximum recall @ precision >= 0.15

Remaining deployment steps for this task:

Details

SubjectRepoBranchLines +/-
Remove old thresholds syntax parsermediawiki/extensions/ORESmaster+2 -97
Update default thresholds to new syntaxmediawiki/extensions/ORESmaster+7 -7
Update ORES threshold config to the new syntaxoperations/mediawiki-configmaster+62 -294
Fix new ORES threshold syntaxoperations/mediawiki-configmaster+62 -62
Convert ORES tresholds config to new syntax (beta)operations/mediawiki-configmaster+232 -0
Customize query in gerrit

Related Objects

Event Timeline

awight created this task.Nov 22 2017, 3:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 22 2017, 3:31 PM
awight edited projects, added Machine-Learning-Team (Active Tasks); removed Machine-Learning-Team.Mar 1 2018, 10:57 PM
awight updated the task description. (Show Details)Mar 1 2018, 11:03 PM
gerritbot subscribed.Mar 2 2018, 3:14 PM

Change 415861 had a related patch set uploaded (by Awight; owner: Awight):
[operations/mediawiki-config@master] Convert ORES tresholds config to new syntax (beta)

https://gerrit.wikimedia.org/r/415861

gerritbot added a project: Patch-For-Review.Mar 2 2018, 3:14 PM
gerritbot added a comment.Mar 7 2018, 8:03 PM

Change 415861 merged by jenkins-bot:
[operations/mediawiki-config@master] Convert ORES tresholds config to new syntax (beta)

https://gerrit.wikimedia.org/r/415861

Halfak assigned this task to awight.Mar 12 2018, 3:51 PM
Halfak moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.
awight removed a project: Patch-For-Review.Mar 13 2018, 4:07 PM
awight moved this task from Review to Parked on the Machine-Learning-Team (Active Tasks) board.

This isn't working. I'll look for debug info and then revert the current patch.

gerritbot added a comment.Mar 13 2018, 5:01 PM

Change 419223 had a related patch set uploaded (by Awight; owner: Awight):
[operations/mediawiki-config@master] Fix new ORES threshold syntax

https://gerrit.wikimedia.org/r/419223

gerritbot added a project: Patch-For-Review.Mar 13 2018, 5:01 PM
gerritbot added a comment.Mar 13 2018, 5:14 PM

Change 419223 merged by jenkins-bot:
[operations/mediawiki-config@master] Fix new ORES threshold syntax

https://gerrit.wikimedia.org/r/419223

Stashbot subscribed.Mar 13 2018, 5:19 PM

Mentioned in SAL (#wikimedia-operations) [2018-03-13T17:19:40Z] <awight@tin> Started scap: Beta: Fix ORES thresholds and enable JADE, T181159, T176333

Stashbot mentioned this in T176333: Deploy JADE prototype in Beta Cluster.Mar 13 2018, 5:19 PM
awight added a comment.Mar 13 2018, 5:48 PM

Looks good now.

Stashbot added a comment.Mar 13 2018, 6:46 PM

Mentioned in SAL (#wikimedia-operations) [2018-03-13T18:46:55Z] <demon@tin> scap failed: LockFailedError Failed to acquire lock "/var/lock/scap.operations_mediawiki-config.lock"; owner is "awight"; reason is "Beta: Fix ORES thresholds and enable JADE, T181159, T176333" (duration: 00m 00s)

Stashbot added a comment.Mar 13 2018, 6:47 PM

Mentioned in SAL (#wikimedia-operations) [2018-03-13T18:47:38Z] <demon@tin> scap failed: LockFailedError Failed to acquire lock "/var/lock/scap.operations_mediawiki-config.lock"; owner is "awight"; reason is "Beta: Fix ORES thresholds and enable JADE, T181159, T176333" (duration: 00m 00s)

gerritbot added a comment.Mar 14 2018, 6:34 PM

Change 419499 had a related patch set uploaded (by Awight; owner: Awight):
[operations/mediawiki-config@master] Update ORES threshold config to the new syntax

https://gerrit.wikimedia.org/r/419499

gerritbot added a comment.Mar 14 2018, 11:13 PM

Change 419499 merged by jenkins-bot:
[operations/mediawiki-config@master] Update ORES threshold config to the new syntax

https://gerrit.wikimedia.org/r/419499

Stashbot added a comment.Mar 14 2018, 11:18 PM

Mentioned in SAL (#wikimedia-operations) [2018-03-14T23:18:57Z] <tgr@tin> Synchronized wmf-config/InitialiseSettings-labs.php: T181159 Update ORES threshold config to the new syntax (duration: 01m 15s)

Stashbot added a comment.Mar 14 2018, 11:21 PM

Mentioned in SAL (#wikimedia-operations) [2018-03-14T23:21:19Z] <tgr@tin> Synchronized wmf-config/InitialiseSettings.php: T181159 Update ORES threshold config to the new syntax (duration: 01m 20s)

gerritbot added a comment.Mar 15 2018, 9:09 PM

Change 419856 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/ORES@master] Update default thresholds to new syntax

https://gerrit.wikimedia.org/r/419856

gerritbot added a comment.Mar 15 2018, 9:09 PM

Change 419857 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/ORES@master] Remove old thresholds syntax parser

https://gerrit.wikimedia.org/r/419857

awight moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Mar 15 2018, 9:09 PM
gerritbot added a comment.Mar 16 2018, 7:27 PM

Change 419856 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Update default thresholds to new syntax

https://gerrit.wikimedia.org/r/419856

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)).Mar 16 2018, 8:01 PM
awight added a comment.Mar 19 2018, 4:24 PM

Remaining deployment steps for this task:

awight moved this task from Review to Pending deployment on the Machine-Learning-Team (Active Tasks) board.Mar 19 2018, 4:25 PM
awight updated the task description. (Show Details)Mar 19 2018, 5:35 PM
awight updated the task description. (Show Details)Mar 19 2018, 5:47 PM
awight updated the task description. (Show Details)
awight updated the task description. (Show Details)Mar 19 2018, 6:23 PM
awight added a subscriber: Ladsgroup.

@Ladsgroup This is ready for CR and merge now: https://gerrit.wikimedia.org/r/419857

awight moved this task from Pending deployment to Review on the Machine-Learning-Team (Active Tasks) board.Mar 19 2018, 6:24 PM
gerritbot added a comment.Mar 19 2018, 6:58 PM

Change 419857 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Remove old thresholds syntax parser

https://gerrit.wikimedia.org/r/419857

awight moved this task from Review to Pending deployment on the Machine-Learning-Team (Active Tasks) board.Mar 19 2018, 7:14 PM
awight moved this task from Pending deployment to Completed on the Machine-Learning-Team (Active Tasks) board.Apr 9 2018, 6:33 PM
awight mentioned this in Blog Post: Status Update (May 2, 2018).May 2 2018, 6:43 PM
awight closed this task as Resolved.May 2 2018, 6:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits