Page MenuHomePhabricator
Create Task
Maniphest T181318

Kill off $wgStyleVersion
Closed, ResolvedPublic
Actions

Description

CommonSettings has this amusing addition

# Style version appendix
# Shouldn't be needed much in 1.17 due to ResourceLoader, but some legacy things still need it
$wgStyleVersion .= '-4';

Plus... https://github.com/wikimedia/mediawiki/commit/2d55b1670f34dc63ecc9ce4be20f1b04610d191b - It's been 303 for 6 years

I'm guessing it adds little/no value at this point. And in https://github.com/wikimedia/operations-mediawiki-config/blame/master/wmf-config/CommonSettings.php#L2396 is at at least 6 years too

Is it past time for it to go away now?

Details

SubjectRepoBranchLines +/-
Drop $wgStyleVersion, deprecated in 1.31 and now unusedmediawiki/coremaster+2 -11
Skin: Drop appending of wgStyleVersion in getSkinStylePath()mediawiki/coremaster+6 -6
OutputPage: Remove appending of wgStyleVersion to legacy resourcesmediawiki/coremaster+8 -9
OutputPage: Remove support for non-existent /w/skins/common directorymediawiki/coremaster+10 -8
Remove $wgStyleVersionmediawiki/extensions/SemanticPageMakermaster+2 -2
Remove $wgStyleVersionmediawiki/extensions/ApiExplorermaster+6 -11
Remove $wgStyleVersionmediawiki/extensions/InterwikiIntegrationmaster+3 -3
Soft deprecate $wgStyleVersion (add @deprecated)mediawiki/coremaster+2 -0
Remove $wgStyleVersion appending in CommonSettingsoperations/mediawiki-configmaster+0 -4
Customize query in gerrit

Event Timeline

Reedy created this task.Nov 24 2017, 11:00 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptNov 24 2017, 11:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Reedy updated the task description. (Show Details)Nov 24 2017, 11:00 PM
gerritbot subscribed.Nov 24 2017, 11:02 PM

Change 393353 had a related patch set uploaded (by Reedy; owner: Reedy):
[operations/mediawiki-config@master] Remove $wgStyleVersion appending in CommonSettings

https://gerrit.wikimedia.org/r/393353

gerritbot added a project: Patch-For-Review.Nov 24 2017, 11:02 PM
gerritbot added a comment.Nov 24 2017, 11:12 PM

Change 393354 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Kill off $wgStyleVersion

https://gerrit.wikimedia.org/r/393354

Reedy added a comment.Nov 24 2017, 11:15 PM

I would suggest we don't really need to deprecate it either, it can probably just go...

Paladox subscribed.Nov 24 2017, 11:44 PM
Nemo_bis awarded a token.Nov 25 2017, 11:20 AM
gerritbot added a comment.Nov 27 2017, 8:14 PM

Change 393353 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove $wgStyleVersion appending in CommonSettings

https://gerrit.wikimedia.org/r/393353

Krinkle triaged this task as Medium priority.Nov 27 2017, 8:25 PM
Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.
Krinkle moved this task from Inbox to Accepted Enhancement on the MediaWiki-ResourceLoader board.
Krinkle removed a project: MediaWiki-General.
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.
gerritbot added a comment.Nov 27 2017, 8:57 PM

Change 393354 merged by jenkins-bot:
[mediawiki/core@master] Soft deprecate $wgStyleVersion (add @deprecated)

https://gerrit.wikimedia.org/r/393354

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)).Nov 27 2017, 9:00 PM
Reedy removed a project: Patch-For-Review.Nov 27 2017, 9:06 PM
gerritbot added a comment.Nov 27 2017, 9:20 PM

Change 393662 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/InterwikiIntegration@master] Remove $wgStyleVersion

https://gerrit.wikimedia.org/r/393662

gerritbot added a project: Patch-For-Review.Nov 27 2017, 9:20 PM

Change 393663 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SemanticPageMaker@master] Remove $wgStyleVersion

https://gerrit.wikimedia.org/r/393663

gerritbot added a comment.Nov 27 2017, 9:24 PM

Change 393665 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/ApiExplorer@master] Remove $wgStyleVersion

https://gerrit.wikimedia.org/r/393665

gerritbot added a comment.Nov 27 2017, 9:24 PM

Change 393662 merged by jenkins-bot:
[mediawiki/extensions/InterwikiIntegration@master] Remove $wgStyleVersion

https://gerrit.wikimedia.org/r/393662

gerritbot added a comment.Nov 28 2017, 12:08 AM

Change 393665 merged by jenkins-bot:
[mediawiki/extensions/ApiExplorer@master] Remove $wgStyleVersion

https://gerrit.wikimedia.org/r/393665

gerritbot added a comment.Nov 28 2017, 12:08 AM

Change 393663 merged by jenkins-bot:
[mediawiki/extensions/SemanticPageMaker@master] Remove $wgStyleVersion

https://gerrit.wikimedia.org/r/393663

Krinkle removed projects: Patch-For-Review, MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)).May 21 2018, 8:42 PM
gerritbot added a comment.May 21 2018, 9:08 PM

Change 434421 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] OutputPage: Remove support for non-existent /w/skins/common directory

https://gerrit.wikimedia.org/r/434421

gerritbot added a project: Patch-For-Review.May 21 2018, 9:08 PM
gerritbot added a comment.May 23 2018, 6:01 PM

Change 434421 merged by jenkins-bot:
[mediawiki/core@master] OutputPage: Remove support for non-existent /w/skins/common directory

https://gerrit.wikimedia.org/r/434421

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).May 23 2018, 7:00 PM
gerritbot added a comment.May 23 2018, 8:00 PM

Change 434422 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] OutputPage: Remove appending of wgStyleVersion to legacy resources

https://gerrit.wikimedia.org/r/434422

gerritbot added a comment.May 23 2018, 9:34 PM

Change 434422 merged by jenkins-bot:
[mediawiki/core@master] OutputPage: Remove appending of wgStyleVersion to legacy resources

https://gerrit.wikimedia.org/r/434422

gerritbot added a comment.May 23 2018, 10:01 PM

Change 434810 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Skin::getSkinStylePath: Drop appending wgStyleVersion, deprecated

https://gerrit.wikimedia.org/r/434810

gerritbot added a comment.May 23 2018, 10:01 PM

Change 434811 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Drop $wgStyleVersion, deprecated in 1.31 and now unused

https://gerrit.wikimedia.org/r/434811

gerritbot added a comment.May 24 2018, 2:05 PM

Change 434810 merged by jenkins-bot:
[mediawiki/core@master] Skin: Drop appending of wgStyleVersion in getSkinStylePath()

https://gerrit.wikimedia.org/r/434810

Krinkle claimed this task.May 24 2018, 2:20 PM
Krinkle edited projects, added Performance-Team; removed Performance-Team (Radar).
Krinkle moved this task from Unsorted to Needs removal on the Technical-Debt board.
Krinkle added a project: Wikimedia-Performance-publish.
Krinkle moved this task from Untriaged to Ready for write-up on the Wikimedia-Performance-publish board.
gerritbot added a comment.May 24 2018, 2:34 PM

Change 434811 merged by jenkins-bot:
[mediawiki/core@master] Drop $wgStyleVersion, deprecated in 1.31 and now unused

https://gerrit.wikimedia.org/r/434811

Krinkle closed this task as Resolved.May 26 2018, 10:16 AM
Krinkle removed a project: Patch-For-Review.
Krinkle moved this task from Ready for write-up to Misc bookmarks on the Wikimedia-Performance-publish board.Sep 10 2022, 12:09 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL