SyntaxHighlight should run Pygments with Python 3
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Dec 14 2017, 8:28 AM

Description

Debian has started warning (https://lintian.debian.org/tags/dependency-on-python-version-marked-for-end-of-life.html) about things that use Python 2 and not 3 - including MediaWiki via SyntaxHighlight/Pygments.

I *think* we just need to update https://phabricator.wikimedia.org/diffusion/ESHG/browse/master/pygments/create_pygmentize_bundle to point to /usr/bin/python3, and regenerate the bundle. And then announce/document that highlighting requires Python 3 to be installed.

Tagging as a 1.31 blocker as this extension is bundled with the tarball and the 1.31 support cycle is planned to end in 2021, while Python 2 goes EOL in 2020.

Details

Subject	Repo	Branch	Lines +/-
Run Pygments using Python 3	mediawiki/extensions/SyntaxHighlight_GeSHi	REL1_30	+9 -13
Run Pygments using Python 3	mediawiki/extensions/SyntaxHighlight_GeSHi	REL1_29	+9 -13
Run Pygments using Python 3	mediawiki/extensions/SyntaxHighlight_GeSHi	master	+9 -13
mediawiki: Remove unused python-pygments package	operations/puppet	production	+0 -1

Customize query in gerrit

Related Objects

Mentioned In: T207021: quibble-vendor-mysql-hhvm-docker failing on SyntaxHighlight_GeSHi due to "Failed to invoke Pygments: /usr/bin/env: python: No such file or directory"
Mentioned Here: T197669: Formalise and Announce REL1_29 EOL

Event Timeline

Legoktm created this task.Dec 14 2017, 8:28 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 14 2017, 8:28 AM

Change 400457 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Run Pygments using Python 3

https://gerrit.wikimedia.org/r/400457

Change 400458 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[operations/puppet@production] mediawiki: Ensure Python 3 is available for Pygments

https://gerrit.wikimedia.org/r/400458

Legoktm claimed this task.Dec 28 2017, 2:57 AM

rafidaslam subscribed.Dec 30 2017, 3:13 PM

Change 400457 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Run Pygments using Python 3

https://gerrit.wikimedia.org/r/400457

The puppet patch is just extra cleanup, Python 3 is already installed on all appservers.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Jan 2 2018, 12:00 PM

Krinkle awarded a token.Jan 4 2018, 10:01 PM

Change 400458 merged by Muehlenhoff:
[operations/puppet@production] mediawiki: Remove unused python-pygments package

https://gerrit.wikimedia.org/r/400458

Change 440873 had a related patch set uploaded (by Reedy; owner: Legoktm):
[mediawiki/extensions/SyntaxHighlight_GeSHi@REL1_29] Run Pygments using Python 3

https://gerrit.wikimedia.org/r/440873

Change 440874 had a related patch set uploaded (by Reedy; owner: Legoktm):
[mediawiki/extensions/SyntaxHighlight_GeSHi@REL1_30] Run Pygments using Python 3

https://gerrit.wikimedia.org/r/440874

Change 440873 abandoned by Krinkle:
Run Pygments using Python 3

Reason:
Task T197669 was declined per T197669.

https://gerrit.wikimedia.org/r/440873

hashar mentioned this in T207021: quibble-vendor-mysql-hhvm-docker failing on SyntaxHighlight_GeSHi due to "Failed to invoke Pygments: /usr/bin/env: python: No such file or directory".Oct 16 2018, 7:35 AM

Change 440874 abandoned by Reedy:
Run Pygments using Python 3

https://gerrit.wikimedia.org/r/440874