Page MenuHomePhabricator
Create Task
Maniphest T183819

[Unit testing] For an existing newsletter `FooBarExists`, API edit should reflect changes
Closed, ResolvedPublic
Actions

Description

Follow instructions as per https://phabricator.wikimedia.org/T183817 to mock an API edit an existing Newsletter FooBarExists. This unit test should:

The original newsletter (Newsletter:FooBarExists) can be created without using APIEdits, and just by new Newsletter() with values.

  1. try updating description
  2. try updating main page

Details

SubjectRepoBranchLines +/-
Add unit tests for changing description and main page of newsletters via APImediawiki/extensions/Newslettermaster+64 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

01tonythomas created this task.Dec 30 2017, 3:55 PM
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.Dec 31 2017, 1:14 PM
Pppery edited parent tasks, added: T183817: [Unit testing] Add unit tests to API operations on Newsletter namespace; removed: T183818: [Unit testing] On successful API edit to newsletter namespace, a newsletter should be created .Dec 31 2017, 2:13 PM
gerritbot subscribed.Dec 31 2017, 3:31 PM

Change 401185 had a related patch set uploaded (by Pppery; owner: Pppery):
[mediawiki/extensions/Newsletter@master] Add unit tests for changing description and main page of newsletters via API

https://gerrit.wikimedia.org/r/401185

gerritbot added a project: Patch-For-Review.Dec 31 2017, 3:31 PM
Pppery claimed this task.Dec 31 2017, 3:33 PM
01tonythomas closed this task as Resolved.Dec 31 2017, 4:59 PM

Thanks, works!

gerritbot added a comment.Dec 31 2017, 5:00 PM

Change 401185 merged by jenkins-bot:
[mediawiki/extensions/Newsletter@master] Add unit tests for changing description and main page of newsletters via API

https://gerrit.wikimedia.org/r/401185

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Dec 31 2017, 6:00 PM
01tonythomas closed subtask T183820: [Unit testing] For an existing newsletter `FooBarExists`, API edits to add publishers should work as Resolved.Feb 1 2018, 4:44 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL