Page MenuHomePhabricator
Create Task
Maniphest T183981

Enable wgKartographerStaticMapframe for lvwiki
Closed, ResolvedPublic
Actions

Description

Per comment at T183661 wgKartographerStaticMapframe should be enabled for almost all projects with mapframe. I'll prepare patch and wait for review.

Martin Urbanec / Urbanecm

Details

SubjectRepoBranchLines +/-
Enable wgKartographerStaticMapframe for lvwikioperations/mediawiki-configmaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm created this task.Jan 2 2018, 7:30 PM
Restricted Application added a project: User-Urbanecm. · View Herald TranscriptJan 2 2018, 7:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Urbanecm mentioned this in T183661: Enable <mapframe> on Latvian Wikipedia.Jan 2 2018, 7:30 PM
gerritbot subscribed.Jan 2 2018, 7:32 PM

Change 401590 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Enable wgKartographerStaticMapframe for all projects

https://gerrit.wikimedia.org/r/401590

gerritbot added a project: Patch-For-Review.Jan 2 2018, 7:32 PM
Urbanecm added subscribers: debt, MaxSem.Jan 2 2018, 7:33 PM

@debt & @MaxSem: Can you review the above please? I hope it'll not enable mapframe everywhere. Otherwise we'll need to create dblist for projects that it's enabled at.

debt added a comment.Jan 2 2018, 7:36 PM
In T183981#3868856, @Urbanecm wrote:

@debt & @MaxSem: Can you review the above please? I hope it'll not enable mapframe everywhere. Otherwise we'll need to create dblist for projects that it's enabled at.

This will turn on the static map frame service for every wiki, which is not desired (ie: Wikivoyage), @Urbanecm.

Urbanecm renamed this task from Enable wgKartographerStaticMapframe for all projects to Enable wgKartographerStaticMapframe for lvwiki.Jan 2 2018, 7:42 PM
Urbanecm updated the task description. (Show Details)

That's what I worried... Ok, let's have the list somewhat duplicated... Can you have a look at the patch now?

Urbanecm moved this task from Backlog to To deploy on the User-Urbanecm board.Jan 2 2018, 7:44 PM
Urbanecm triaged this task as High priority.Jan 2 2018, 7:51 PM
Restricted Application added a subscriber: Dereckson. · View Herald TranscriptJan 2 2018, 7:51 PM
debt added a comment.Jan 2 2018, 8:53 PM

Looks good to me, @Urbanecm, I've +1'd the edited patch. :)

debt added a project: Maps-Sprint.Jan 2 2018, 8:54 PM
debt moved this task from Backlog to Needs review on the Maps-Sprint board.
debt mentioned this in T183764: Turn on mapframe for Arabic Wikipedia.Jan 2 2018, 9:00 PM
gerritbot added a comment.Jan 8 2018, 2:13 PM

Change 401590 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable wgKartographerStaticMapframe for lvwiki

https://gerrit.wikimedia.org/r/401590

Stashbot subscribed.Jan 8 2018, 2:21 PM

Mentioned in SAL (#wikimedia-operations) [2018-01-08T14:21:50Z] <hashar@tin> Synchronized wmf-config/InitialiseSettings.php: Enable wgKartographerStaticMapframe for lvwiki - T183981 (duration: 00m 51s)

Urbanecm closed this task as Resolved.Jan 8 2018, 2:25 PM
debt moved this task from Needs review to Done on the Maps-Sprint board.Jan 8 2018, 2:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL