Page MenuHomePhabricator
Create Task
Maniphest T184008

Language fallback for search can fail when rescore profile doesn't exist on target wiki
Closed, ResolvedPublic
Actions

Description

Example failure: https://en.wikipedia.org/w/api.php?action=query&list=search&srsearch=sistema%20parlamentario%20con%20sede%20de%20gobierno&srenablerewrites=yes&srinterwiki=1
Log message: https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2018.01.02/mediawiki/?id=AWC4yTHthTduSC7pBP2q
Stack trace:

#0 /srv/mediawiki/php-1.31.0-wmf.12/extensions/CirrusSearch/includes/Search/RescoreBuilders.php(76): CirrusSearch\Search\RescoreBuilder->getSupportedProfile(string)
#1 /srv/mediawiki/php-1.31.0-wmf.12/extensions/CirrusSearch/includes/Search/SearchContext.php(599): CirrusSearch\Search\RescoreBuilder->__construct(CirrusSearch\Search\SearchContext)
#2 /srv/mediawiki/php-1.31.0-wmf.12/extensions/CirrusSearch/includes/Search/SearchRequestBuilder.php(109): CirrusSearch\Search\SearchContext->getRescore()
#3 /srv/mediawiki/php-1.31.0-wmf.12/extensions/CirrusSearch/includes/Searcher.php(516): CirrusSearch\Search\SearchRequestBuilder->build()
#4 /srv/mediawiki/php-1.31.0-wmf.12/extensions/CirrusSearch/includes/Searcher.php(360): CirrusSearch\Searcher->buildSearch()
#5 /srv/mediawiki/php-1.31.0-wmf.12/extensions/CirrusSearch/includes/CirrusSearch.php(388): CirrusSearch\Searcher->searchText(string, boolean)
#6 /srv/mediawiki/php-1.31.0-wmf.12/extensions/CirrusSearch/includes/CirrusSearch.php(303): CirrusSearch->searchTextReal(string, CirrusSearch\HashSearchConfig, boolean)
#7 /srv/mediawiki/php-1.31.0-wmf.12/extensions/CirrusSearch/includes/CirrusSearch.php(183): CirrusSearch->searchTextSecondTry(string, Status)
#8 /srv/mediawiki/php-1.31.0-wmf.12/includes/api/ApiQuerySearch.php(97): CirrusSearch->searchText(string)
#9 /srv/mediawiki/php-1.31.0-wmf.12/includes/api/ApiQuerySearch.php(43): ApiQuerySearch->run()
#10 /srv/mediawiki/php-1.31.0-wmf.12/includes/api/ApiQuery.php(253): ApiQuerySearch->execute()
#11 /srv/mediawiki/php-1.31.0-wmf.12/includes/api/ApiMain.php(1582): ApiQuery->execute()
#12 /srv/mediawiki/php-1.31.0-wmf.12/includes/api/ApiMain.php(544): ApiMain->executeAction()
#13 /srv/mediawiki/php-1.31.0-wmf.12/includes/api/ApiMain.php(515): ApiMain->executeActionWithErrorHandling()
#14 /srv/mediawiki/php-1.31.0-wmf.12/api.php(94): ApiMain->execute()
#15 /srv/mediawiki/w/api.php(3): include(string)
#16 {main}

It looks like what's happening here is SearchApi.php trait is setting the default SearchEngine::FT_QUERY_INDEP_PROFILE_TYPE based on the local wiki configuration, and when loading the config and querying the other wiki the profile doesn't exist. First level fix should probably be to only set the profile if a user explicitly provided one. That only solves the most obvious occurance of the problem though, a user explicitly setting the qiprofile can still experience the error. We might need to have a way for the non-existent profile to fallback to the default profile instead of bailing out.

Details

SubjectRepoBranchLines +/-
Use target wiki config when checking rescore profilemediawiki/extensions/CirrusSearchmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

EBernhardson created this task.Jan 2 2018, 9:53 PM
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptJan 2 2018, 9:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
EBernhardson added a parent task: T142795: Offer interwiki search with language detection functionality over the API.Jan 2 2018, 10:01 PM
debt triaged this task as Medium priority.Jan 2 2018, 10:19 PM
debt mentioned this in T142795: Offer interwiki search with language detection functionality over the API.
debt moved this task from needs triage to Up Next on the Discovery-Search board.
dcausse added a comment.Jan 3 2018, 9:30 AM

I remember that it's due to the type of API param we use. When setting an array as ApiBase::PARAM_TYPE a default must be provided IIRC.
The use of arrays was a way to expose the list of possible profiles to use but the drawback was that the API would fail if you provide an unknown param. I think this is wrong, I agree, cirrus should be able to know if a profile was explicitly set by the user.

Alternatively one quick fix could be for cirrus to not fail in case of missing rescore profile by checking the target wiki config instead of the local one. Looking at the code we check the wrong config object.

gerritbot subscribed.Jan 3 2018, 9:43 AM

Change 401703 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Use target wiki config when checking rescore profile

https://gerrit.wikimedia.org/r/401703

gerritbot added a project: Patch-For-Review.Jan 3 2018, 9:43 AM
gerritbot added a comment.Jan 3 2018, 6:59 PM

Change 401703 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Use target wiki config when checking rescore profile

https://gerrit.wikimedia.org/r/401703

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)).Jan 3 2018, 7:00 PM
debt edited projects, added Discovery-Search (Current work); removed Discovery-Search.Jan 11 2018, 6:16 PM
debt moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.
EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Feb 13 2018, 7:57 PM
debt closed this task as Resolved.Feb 26 2018, 3:36 PM
debt claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits