Page MenuHomePhabricator

Fatal PHP Errors while viewing an image
Closed, ResolvedPublic

Description

Author: charlie

Description:
While trying out the new [[File:]] namespace rename, I encountered this fatal error while viewing an image:

Fatal error: Call to a member function toHtml() on a non-object in /home/yourwiki/htdocs/html/w/includes/ImagePage.php on line 936

Any ideas?


Version: 1.14.x
Severity: blocker
URL: http://meta.yourwiki.net/wiki/File:Ambox_notice.png

Details

Reference
bz16411

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:25 PM
bzimport set Reference to bz16411.

charlie wrote:

It's working for some images, but it seems to be broken for all Ambox images, maybe more.

Issue confirmed. Cannot reproduce it, yet, though. Have only seen 3 occurrences with out users logged from Betawiki to MediaWiki-Internationalization so far.

Can readily reproduce as of current trunk (r34824). Narrowed it down to some mis-handling of external data in the ForeignApiRepo, but trying to figure out exactly why. Enabling thumb caching suppresses the errors, but still produces invalid output (no thumbs).

Fixed in r43825 (had to remove the findBySha1 functionality for now).