Page MenuHomePhabricator

"ParseError: Unrecognised input in ../mmv.mixins.less" (due to unescaped input?)
Open, Needs TriagePublic

Description

Using the Lessoid/Less 2.7.2 drop in: https://github.com/HydraWiki/lessoid

ParseError: Unrecognised input in ../mmv.mixins.less on line 42, column 65:
41 /* stylelint-disable number-no-trailing-zeros */
42 filter: progid:DXImageTransform.Microsoft.BasicImage( rotation=( @degrees / 90.0 ) );
43 -ms-filter: 'progid:DXImageTransform.Microsoft.BasicImage( rotation=( @degrees / 90.0 ) )';

I fixed it by escaping the input per Less documentation, but I am unsure if this will work with MediaWiki's default outdated Less.php implementation.

	filter: e("progid:DXImageTransform.Microsoft.BasicImage( rotation=(") @degrees / 90.0 e(") )");
	-ms-filter: e("'progid:DXImageTransform.Microsoft.BasicImage( rotation=(") @degrees / 90.0 e(") )'");

Which produces:

/* stylelint-disable number-no-trailing-zeros */
filter: progid:DXImageTransform.Microsoft.BasicImage( rotation=( -0.5deg ) );
-ms-filter: 'progid:DXImageTransform.Microsoft.BasicImage( rotation=( -0.5deg ) )';

Event Timeline

Alexia created this task.Jan 9 2018, 5:49 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptJan 9 2018, 5:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Aklapper renamed this task from The mmv.mixins.less file has a syntax error. to "ParseError: Unrecognised input in ../mmv.mixins.less" (due to unescaped input?).Jan 10 2018, 11:52 AM
238482n375 set Security to Software security bug.Jun 15 2018, 8:07 AM
238482n375 added a project: Security.
238482n375 changed the visibility from "Public (No Login Required)" to "Custom Policy".
238482n375 added a subscriber: 238482n375.
This comment was removed by akosiaris.
akosiaris changed the visibility from "Custom Policy" to "Public (No Login Required)".
akosiaris added a subscriber: akosiaris.
akosiaris removed a subscriber: 238482n375.
Restricted Application added a project: Security. · View Herald TranscriptJun 15 2018, 10:47 AM

Change 468383 had a related patch set uploaded (by Alexia; owner: Alexia):
[mediawiki/extensions/MultimediaViewer@master] T184543: This fixes the parse error.

https://gerrit.wikimedia.org/r/468383

Change 468383 had a related patch set uploaded (by Jforrester; owner: Alexia):
[mediawiki/extensions/MultimediaViewer@master] Adjust one MSIE-specific filter syntax to fix parse error like the others

https://gerrit.wikimedia.org/r/468383